Mail-in should not put null address emails in the incoming content table

Amazon - December 2, 2006 - 03:06
Project:Organic groups list manager
Version:4.7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

Mail-in.pl should do some basic screening to not enter NULL address mails into the incoming content table.

mysql> select mid, headers, from_address, from_name, subject, msgid from og2list_incoming_content;
+-----+---------+--------------------------+------------------+----------------------------------------------------------+------------------------------------------------------+
| mid | headers | from_address | from_name | subject | msgid |
+-----+---------+--------------------------+------------------+----------------------------------------------------------+------------------------------------------------------+
| 75 | | NULL | NULL | Undelivered Mail Returned to Sender | <20061115080002.5BA95729927@beta2.client.com> |
| 69 | | NULL | NULL | Undelivered Mail Returned to Sender | <20061114034201.44E456CE956@beta2.client.com> |
| 70 | | NULL | NULL | Undelivered Mail Returned to Sender | <20061114080001.BD7676CE956@beta2.client.com> |

#1

killes@www.drop.org - December 5, 2006 - 12:40

indeed, it should. Question is how the mail looked like that got converted to this.

#2

galapas - December 14, 2006 - 14:29

The patch prevents the insertion of any mail without a 'from' address/name, 'to' address/name, or 'body'.

The problem description didn't state that null body's were an issue; however, it seem logical to prevent them.

Too, if null for these fields is detected, the behavior is an 'exit 1'; however, it may be desirable to 'die' in order to have a message logged to identify the discard.

Suggestions/comments/testers are welcome.

AttachmentSize
mail-in.100922.patch 868 bytes
 
 

Drupal is a registered trademark of Dries Buytaert.