this is a regression of Path alias memory cache is broken

per docs drupal_lookup_path() should return FALSE if we did not find an alias or source-path.
Since this commit we return NULL...

because of this I can't redo the patch url() does not recognize if $path == frontpage.

CommentFileSizeAuthor
#7 drupal_lookup_path_simplify.patch1.02 KBchx
#2 path.patch_1.txt692 byteschx
drupal_lookup_path_regression.patch.txt1.32 KBTobias Maier

Comments

Tobias Maier’s picture

Tobias Maier commented
Title: drupal_lookup_path returns NULL instead of FALSE » drupal_lookup_path() returns NULL instead of FALSE
chx’s picture

chx commented
StatusFileSize
new path.patch_1.txt692 bytes

I can't say I like the patch -- the idea is sound, but the implementation is a bit chatty. How about this one?

Tobias Maier’s picture

Tobias Maier commented

great!
I like it

robertdouglass’s picture

robertdouglass commented

Whee! More drupal_lookup_path excitement, how nice. Haven't tested yet, just subscribing.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Actually... I implemented this for http://drupal.org/node/100301 and that patch has been applied to drupal.org where it runs for days now so this has been tested to death already :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

chx’s picture

chx commented
Status: Fixed » Needs review
StatusFileSize
new drupal_lookup_path_simplify.patch1.02 KB

as you have comitted the db_result patch there is no more need for this one as db_result now can't return NULL. Sorry for not making this clear previously.

m3avrck’s picture

m3avrck commented

Bumping for more eyes, this should go in. Looks ok to me.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)