I think the string 'Interest Groups' is not being run through t() and hence cannot be translated.

-Daniel
DealFever

CommentFileSizeAuthor
#1 mailchimp.module.interest-groups.patch3.14 KBbocaj

Comments

bocaj’s picture

bocaj commented
Status: Active » Needs review
StatusFileSize
new mailchimp.module.interest-groups.patch3.14 KB

To add to this, it would make sense to me to have 'Interest Groups' be admin-configurable.

I have created a patch that adds the ability to turn the fieldset wrapper off, leaving just the interest group title set in Mailchimp and the list of options. Also, if the fieldset is used, the title is admin-configurable and translatable.

This is rolled against the latest 2.x-dev.

kerberos’s picture

kerberos commented

Great idea! We are currently using some form_alters and CSS to get rid of the fieldset wrapper but this is much more elegant.

-Daniel

kerberos’s picture

kerberos commented
Status: Needs review » Reviewed & tested by the community

We tried the patch and can confirm that it works like a charm.

-Daniel

levelos’s picture

levelos commented
Status: Reviewed & tested by the community » Closed (works as designed)

Re: the original issue, "Interest Groups" is indeed a translatable string in the current release,

    $element['interest_groups_' . $list_id] = array(
      '#type' => 'fieldset',
      '#title' => t('Interest Groups'),
      '#description' => t(''),
      '#collapsible' => TRUE,
      '#collapsed' => !$is_subscribed,
      '#tree' => TRUE,
      '#attributes' => array('class' => 'mailchimp-newsletter-interests-' . $list_id),
    );

Re: adding the additional list options, I'm hesitant at this point. The form is currently already very crowded and difficult to use and I'm generally holding off on new features in the 6.x features focusing those efforts in a completely new 7.x branch, which will include a redesigned admin interface.