Even though D7 doesn't require E_STRICT compliance from modules I think it's a good thing.

Here is what I've got upon trying to create a category:
Strict warning: Only variables should be passed by reference in properties_sql_properties_category_load() (line 140 of /home/nivanov/Workspace/kairion/server/sites/all/modules/contrib/properties/properties_sql/properties_sql.module).

CommentFileSizeAuthor
#4 e_strict2.patch5 KBberdir
#1 e_strict.patch5 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Category: feature » bug
Status: Active » Needs review
StatusFileSize
new e_strict.patch5 KB

I think reset() is causing that warning.

Try this patch...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Bump to trigger the test bot..

Status: Needs review » Needs work

The last submitted patch, e_strict.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new e_strict2.patch5 KB

Better patch.

enikola’s picture

enikola commented

Patch seems to fix the issue. Thank you.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks for testing, commited.

Status: Fixed » Closed (fixed)
Issue tags: -E_STRICT

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +E_STRICT

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.