The description contains a direct link to the context sensitive help which may be disabled. If the user clicks the link and the help is disabled a message is displayed. It would be better to check the ability of the help module before displaying the text with the link.

Earnie
http://for-my-kids.com
http://give-me-an-offer.com

Comments

jjeff’s picture

In the latest HEAD version, I'm only finding this reference within hook_help()... which... in my understanding, doesn't get called unless the help module is enabled.

Anonymous’s picture

Sorry for not being more clear.

The template edit page contains a link to 'help/contemplate'. If the help module is disabled the link gives an error page. But looking now the link is actually miss formed. I'm seeing https://admin.siebunlimited.com/boyde/apps/cms/%3Cem%3E/boyde/apps/cms/?... as the link. Please note that you will not be able to click the link to see the result as it points to a protected directory. If I remove the extra data from the URI I get "Page not found".

NOTE: The malformed URI may be browser specific. I don't remember seeing it before. The malformed URI is displayed with "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.8) Gecko/20061025 Firefox/1.5.0.8". Just checked IE7 and the URI is malformed with it as well.

Earnie
http://for-my-kids.com
http://give-me-an-offer.com

jjeff’s picture

Ahh... got it.

This will be fixed in the next commit to the module.. Hopefully this evening.

jrglasgow’s picture

Version: master » 5.x-1.x-dev
Assigned: Unassigned » jrglasgow
Status: Active » Fixed

I just committed the path to fix this. In Drupal 5 the module_exists function was added that made this easier.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.