The theming implementation in form_builder while functional in D7 doesn't utilize all of the power of the D7 theming layer. In particular, it doesn't take advantage of theme wrappers and instead has separate functions for the prefix, suffix, and assembly of a form element.
This patch reduces the theming functions and move much of the functional work that is done in the current theme functions to pre_render functions so that themers can focus on the output and not the structure.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | form_builder_theming-d7.patch | 12.65 KB | quicksketch |
| #4 | form_builder_theming-d6.patch | 12.87 KB | quicksketch |
| #3 | form-builder-theme-1010254-3.patch | 12.66 KB | David_Rothstein |
| form_builder_theme.patch | 16.46 KB | james.elliott |
Comments
Comment #1
David_Rothstein commentedUpdating the version, now that the 7.x branch is available.
Comment #2
David_Rothstein commentedIt looks like this patch also contains partial fixes for #1019130: Form Builder AJAX system doesn't support Drupal.settings and #1019064: positionForm is output to JSON as an array, rather than rendered HTML.
I think for at least one of them the fix in this patch is not complete though. Because of that, those issues may be easier to review first.
Comment #3
David_Rothstein commentedHere's an updated version of the patch that removes those other parts.
Comment #4
quicksketchThis patch needed a reroll and backport, which I've attached here. I'll review tomorrow hopefully and get this in.
Comment #5
quicksketchAfter some testing everything still seems to be working correctly. Committed. Thanks again for the patches.