Posted by AlexisWilke on December 30, 2010 at 2:56am
1 follower
Jump to:
| Project: | Spam |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
In connection with the comment and what the code looks like, it seems that we should have if (!isset(...)) [with a ! before isset()]....
<?php
// See if module type is set, if not we can't yet perform certain filters.
if (isset($filters['module'])) {
unset($filters['title']);
unset($filters['status']);
unset($filters['feedback']);
}
?>
Comments
#1
Actually, it doesn't even seem to make sense because the loop below accesses title, status and feedback using an additional level of indirection.
<?php[...]
foreach ($filters as $key => $filter) {
$names[$key] = $filter['title'];
if ($filter['options']) {
[...]
?>
It feels like that was a kludge to a some bug and not something that makes sense.
Thank you.
Alexis