I recently upgraded Amazon Store to 6.x-2.1-rc2 and had some major problems with the way Amazon Store pages were displayed in Firefox and Chrome -- pages displayed correctly in IE7.

I'm using the Marinelli theme and, in Firefox and Chrome, the top of the page displayed correctly but the body section was truncated, resulting in most of the Amazon Store content being displayed in the page background area below the theme's footer.

No other pages in the site are causing problems. When I reverted to Amazon Store 6.x-2.0-rc2 the problem went away.

Comments

rfay’s picture

Title: Browser display problem with 6.x-2.1-rc2 » Browser display problem with 6.x-2.1

Thanks for the report on this.

I'm a little surprised you'd be upgrading to 6.x-2.1-rc2, when 6.x-2.1 is the current version. I suspect you mean you upgraded to 6.x-2.1? If not, please report back after upgrading to 2.1.

In 6.x-2.1 there was a significant theme-related change with #597362: Printing multiple product description in one page load results in fatal error. It's possible that that's what happened to you. You should check carefully whether you have a copy of an amazon_store_details_panel.tpl.php in your theme directory, as it will need to be redone because of that change. Please take a look. After you remove it from your theme directory you'll need to rebuild the cache so the theme registry gets rebuilt.

-Randy

clarenza’s picture

Version: 6.x-2.1-rc2 » 6.x-2.1

Hi Randy

You're right, it was 6.x-2.1 that I upgraded to, not 2.1-rc2. I have just tried 2.1 again, same problem.

I have done a search on the file amazon_store_details_panel.tpl.php, it only shows up in the modules / amazon_store directory, nowhere else.

Not totally sure what you mean by rebuilding the caches. I have flushed all caches and updated the database and that makes no difference.

Again I have reverted to 2.0-rc2 and the problem no longer exhibits.

Rob

rfay’s picture

I assume you're using Marinelli 6.x-2.96?

rfay’s picture

I can confirm this with 6.x-2.1 of Amazon Store and Marinelli 6.x-2.96. I imagine it's some shared CSS class or something.

clarenza’s picture

Hi Randy, yes you're correct, I'm using the latest version of the Marinelli theme, 6.x-2.96. Do you think I should pursue it with Marinelli or is it an Amazon Store issue? Are there any reasons not to use Amazon_Store 6.x-2.0rc? Seems to be working OK. Rob

the_g_bomb’s picture

StatusFileSize
new3.19 KB

Not sure if this is related, I have discovered a couple of issues regarding the validity of the html produced by the module in certain situations and also noticed a couple of missing

tags that were causing my theme to display a bit strangely.

I wasn't sure if it was just my hacked module files, but having found this, could someone test the following patch to see how it reacts to solving this issue?

If it doesn't help, then I'll create an issue my self and see what kind of response.

the_g_bomb’s picture

Status: Active » Needs review
rfay’s picture

Version: 6.x-2.1 » 6.x-2.x-dev
StatusFileSize
new2.59 KB

Thanks, @the_g_bomb, that was the ticket, and resolved this problem. Had to adjust the patch as here.

rfay’s picture

Made a mistake by not bringing over the new path stuff.

rfay’s picture

Committed to DRUPAL-6--2

https://drupal.org/cvs?commit=491310

@clarenza, please try out the dev release when it next gets built (in less than 12 hours)

rfay’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Still needs to be done on D7

rfay’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new3.6 KB

Here's the D7 version. It validates (except the iframe for customer reviews, which isn't preferred by the validator). Hoping that does the job. (Still works with D7 marinelli).

rfay’s picture

Title: Browser display problem with 6.x-2.1 » amazon_store_item_detail.tpl.php has invalid markup
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.