Hi,
just tried it out on a drupal 4.7 with postgresql 8.1.5 instead of mysql and taxonomy_image doesn't work.
the table term_image doesn't even get created.
from the looks of the taxonomy_image.install file, the query for pgsql can't work:
the brackets around the table name and the 'unsigned' keyword after 'integer' are both seen as syntax errors by pgsql.
thus, the corrected query would be:

CREATE TABLE term_image (
tid integer NOT NULL default '0',
path varchar(255) NULL,
PRIMARY KEY (tid)
)

could you please correct that in taxonomy_image.install?

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

The brackets should be removed by Drupal's database layer - that is standard practice, not an error.

However, the "unsigned" is apparently wrong. Looking at the way Drupal defines it, I believe "tid" should be something like "integer CHECK (VALUE >= 0)". I don't think path should be NULL either.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Assigned: Unassigned » nancydru
Status: Active » Fixed

Fixed in 5.x version.

jeremy’s picture

jeremy commented

Thanks Nancy!

However, please be sure to include links to your commit message, as found here allowing all easily see exactly what was changed. (A quick search through the past few pages of commits, I did not see any recent taxonomy_image commits from you. Nor do I directly in CVS...?)

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Probably a timing problem:

#
Commit #99471 by nancyw at 17:52
Taxonomy image: /modules/taxonomy_image/po/taxonomy_image.pot 1.1.2.1 @ DRUPAL-5
Taxonomy image: /modules/taxonomy_image/taxonomy_image.install 1.1.4.2 @ DRUPAL-5
Taxonomy image: /modules/taxonomy_image/taxonomy_image.module 1.12.4.2 @ DRUPAL-5

#158882 by nancyw - add "Installed" message, link to settings page, variable deletes.
#158872 by nancyw - remove fractions from width and height.
#191039 by nancyw - add wrapper div around image.
#101116 by nancyw for landover - corrected PostgreSql install.
added translation template.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.