Support the 'drush make' command

colorbox?

It wouldn't be better to do something like this:

core = 6.x
api = 2

libraries[ckeditor][download][type] = "svn"
libraries[ckeditor][download][url] = "http://svn.ckeditor.com/CKEditor/releases/stable/"
libraries[ckeditor][directory_name] = "ckeditor"

Then u can get every time the last stable version?

I commit patch to CVS.

Please check the latest dev release and let me know if you notice any poblems with it. Remember to clear Drupal cache and browsers cache before testing.

Much as I love drush_make and the dream of auto downloading libraries with modules there are numerous situations where including a naked make file will break platform builds.*

I'd suggest renaming ckeditor.make to ckeditor.make.example to avoid problems, this was the solution for colorbox module too (see http://drupal.org/node/839580#comment-4075174 )

* case in point: today I'm doing a new platform build to update modules and have an error:

ckeditor downloaded from                                                             [ok]
http://ftp.drupal.org/files/projects/ckeditor-6.x-1.3.tar.gz.
Found makefile: ckeditor.make                                                        [ok]
No core project specified.                                                           [error]

Basically this makefile doesn't work with drush-7.x-4.4 / drush_make-6.x-2.2 (due to drupal.org infrastructure changes I think, post git migration). End result is that my platform build fails and I now have to fiddle about either pinning ckeditor module to an earlier release, or creating a custom branch to pull in with my own make file, just so I can update.

I was fixed yesterday here: #1099748: Fix drush make error when building a site with CKEditor

If u found any bug pls open new issue with your problem next time.

Greetings

It's not just about the make bug that was fixed, I'm arguing that it's just not good to have make files that auto run, at least at this point (changes in drush_make could make that moot).

What if I want to use a different version of CKEditor itself? Maybe there is a bug I need to avoid and it's fixed in the dev version of CKEditor, for example.
Right now I can specify the version I need in my make file, but the ckeditor.make will override my choice. And AFAIK there is nothing I can do about that. (Well, I can fork ckeditor and change the name of the make file, or manually install it. Not good.)

And if ckeditor.make breaks, it breaks the whole platform build.

Until drush make allows us to override all other make files in our own make files, having them auto run is a bad idea.

So I would again ask, can we please change the name of the make file to ckeditor.make.example? For the sort of people that use drush_make having the make file example is helpful, and it's no big deal for them to copy it over to their own make, keeping it as ckeditor.make takes away the power and flexibility of drush_make.

I create new issue for this feature - #1103872: Change name of ckeditor.make to ckeditor.make.example for drush make module

And this issue i closed, because it's not related with this feature.

Greetings

Renaming the issue back to it's original title, since there ended up a seperate issue for the make file name change.