So book manager is throwing this error when anyone other than the admin user tries to this a content type, aside from book:

warning: Invalid argument supplied for foreach() in [domain]/sites/all/modules/book_manager/book_manager.module on line 603.

I'm not sure why book manager is throwing this warning, since it doesn't seem to affect anything that I can see. Maybe it has something to do with books made simple, which is a module I'm using in addition to book manager?

CommentFileSizeAuthor
#6 book_manager.1011296.patch2.45 KBjgraham

Comments

marcp’s picture

marcp commented

Please try this with 6.x-2.3-beta1 to see if it is still an issue.

iteria’s picture

iteria commented

With the move to 6.x-2.3-beta1 I get this error:

Invalid argument supplied for foreach() in [domain]/sites/all/modules/book_manager/book_manager.module on line 619.

marcp’s picture

marcp commented

It would probably be a good idea to disable Books Made Simple and see if you can reproduce the issue. If you can, please try to provide exact steps to reproduce.

Thanks.

bonobo’s picture

bonobo commented

The dev version of the book manager at http://drupal.org/node/711996 has some improvements that are not in the beta release. The current dev dates from 23 December.

I have been using the dev release pretty extensively in a few different test sites over the last week, and haven't seen any of the issues you are reporting. Like marcp, I suspect some conflict with Book Made Simple; these two modules appear to have some overlapping functionality.

iteria’s picture

iteria commented

You're right. Booksmadesimple does cause the behavior in book manager. I wish that weren't the case. I need both the personal book aspect from book manager and the control booksmadesimple gives me.

jgraham’s picture

jgraham commented
Status: Active » Needs review
StatusFileSize
new book_manager.1011296.patch2.45 KB

iteria,

Can you try the attached patch and report back if you still see the warning?

Regarding the title of this issue; core book allows users with the 'administer book outlines' permission to add *any node type* to any book. Book Manager previously would adjust the list of available nodes to be in sync regardless of a users permission to 'administer book outlines'. Book Manager was recently adjusted to respect core book module's choice in allowing users with 'administer book outlines' to add any node to any book. Perhaps this is the source of the issue?

iteria’s picture

iteria commented

With the patch applied the problem no longer occurs.

With regard to your question, that could be the case considering that booksmadesimple allows me to restrict what types of nodes can be a parent to another given node.

jgraham’s picture

jgraham commented
Status: Needs review » Closed (won't fix)

I have commited the patch in comment 6, this prevents the error message from book_manager.

The other issue(s) mentioned here are "won't fix" as they are a result of the combination of core book, book_manager, and booksmadesimple interacting. It also *seems* as though this can be resolved via careful configuration of permissions amongst the three aforementioned modules.