Posted by wmckinley on December 31, 2010 at 5:08pm
3 followers
| Project: | e-Commerce |
| Version: | master |
| Component: | ec_customer |
| Category: | bug report |
| Priority: | normal |
| Assigned: | gordon |
| Status: | patch (to be ported) |
Issue Summary
Just updated to the new version and I have a bit of a problem. When a customer chooses the use this address box they get an alert that
Error
First name field is required.
Last name field is required.
Street field is required.
City field is required.
so they must go and fill out that form two. it get very confusing for them since when the box is checked that whole set of fields are hidden.
how do I fix this?
Comments
#1
#2
Thanks for this and I think I have been able to replicate this.
I am going to be hopping on a plane home tomorrow and I will see if I can fix this on the way. I did however found another issue which I will need to fix first but I hope to have both of these fixed in the next day or so on the plane ride home.
Thanks again for helping with this and I also will write some tests to make sure that this will not reoccur in the future.
Thanks
Gordon.
#3
I have investigated this and the problem is that the address fields are set to #required which forces them to all be required instead just having the red * to indicated that the fields are required, and not raise the message.
I have added tests as well, will commit as soon as the patch has been tested.
#4
Gordon-
Thank you so much! I will be awaiting the patch.
Wendy
#5
Gordon,
Hi. Thanks so much for looking at this, and for doing it so quickly, too. My wife sent the earlier messages.
If I need to hack something, I usually edit the files directly - I don't usually use shell access. I'm on a shared server and haven't needed to use shell access on this job to date, so I am both unfamiliar with it and I'd need to enable it. Can you get me the patch in the form of modified files instead?
Cheers,
--Will
#6
I gave up waiting on the testing servers and have now committed the patch.
#7
Gordon-
Thank you so much, it works! I have a small list of other issues we are trying to fix ourselves
-on the checkout page there is a box to change the quantity but it does nothing probably should just be removed
-need to make zip and phone number required field
-need a gift message box (I will probably re purpose the ec-address-extra)
We love the flexibility of this cart, thanks so much for all your work
Wendy
#8
Needs to be ported to HEAD
#9
Gordon-
One glitch has come up with the fix. When the customer enters in the billing and shipping address the cart requires them to update cart which clears the credit card information then sets the form back to having ship to this address. We have a couple of customers send orders through without the proper shipping.
We have removed the update cart button and disable the place order button being grayed out so this does not happen. Since they cannot update their quantities anyway.
Wendy
#10
Yes the reason for update cart is that this can cause a change in the amount of the transaction so we need them to do an update.
However I am looking to adding a AJAX request which basically says, here is the new form, has the total changed, if so require update.
What payment gateway are you using? We did a lot of testing with Authorize.net and made sure that was working just before release.
I also don't quite understand
If you could elaborate on this.
#11
On our system the update cart button resets the whole form so it clears the credit card information and it resets the address fields to just have the billing viable and the use the same shipping and billing.
The update cart button does nothing with ours. We are using the paypal gateway (which is not the greatest I wish I had encouraged my client to use authorize).
we disabled it so all works fine now