timothykc [timothykc]

This is a short review of the proposed module.

1. Files available from third-party sites should not committed in drupal.org repository.
2. The license file should not be included, as it is already included from the packaging script.

<?php if ($block->subject): ?>
  <h2<?php print $title_attributes; ?> class="block-title"><?php print $block->subject ?></h2>
<?php endif;?>

There should be a semicolon after each PHP statement.

3. ; Information added by drupal.org packaging script on 2010-12-14
   version = "7.x-1.0"
   core = "7.x"
   project = "Color Tiger"
   datestamp = "1292299363"
   

   Those lines should be removed, for the reason reported in the comment.

4. There is an extra directory that should be removed.

Hello, timothykc.

When you refer to 3rd party files, do you mean scripts such as superfish.js? And if so, is the correct protocol to provide instructions for users to download and place the files themselves?

That is correct; users should get instructions on where to download the files, and where to copy them.

After a brief overview of your theme, here are a couple of things that need to be changed.

1. Your CVS headers should changed from:

   // $Id: block.tpl.php,v 1.3.4.1 2010/11/11 13:52:44 timothykc Exp $
   

   To look like.

   //$Id$
   

   All this info is added by Drupal.org when a commit is made.

2. As per the Drupal coding standards document here: http://drupal.org/node/318#semicolon, you are asked to place a semicolon after all variables.
   Example:
   Line 43 of page.tpl.php.

   <?php print $base_path ?>
   

   Should be replaced with.

   <?php print $base_path; ?>
   

   Great job on this theme, really like the color module support.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

As per previous comment, I am setting this issue as Won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.