undefined function fb_settings() when running update.php or installed from an install profile.

thanks for the report. Usually I include sites/all/modules/fb/fb_settings.inc in my site's settings.php, so I haven't seen this before. I recommend that as a workaround.

Do you know which update is trying to run when this happens?

I run into this issue also. It happens during any update. I turn of the FB module. Run the update. and turn it back on.

Your workaround of adding
include_once './sites/all/modules/fb/fb_settings.inc';

to settings.php worked great

Thanks

Phil

Here's the fix, I think.

I used the patch from Dave Cohen and that seemed to fix my problem running update.php. Thanks!

This was checked in but issue status never updated.

I've added this module to a install profile. At the very end of installation I obtain

An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://urtest/install.php?profile=ur&locale=en&id=1&op=do StatusText: OK ResponseText: Fatal error: Call to undefined function fb_settings() in /var/www/urtest/profiles/ur/modules/fb/fb.module on line 657

The fix above seems not useful at install time.

Fixed with attached patch. Perhaps worth it to use hook_boot() instead of all of this.

with better docs.

Well, that's kind of crappy of drupal to not always call that hook.

I'd rather do something like this in fb_init()

if (!function_exists('fb_settings')) {
  // This may be reached during installation, when hook_custom_theme() is not called.
  fb_custom_theme();
}

That will lead to less duplicated code between fb_init() and fb_custom_theme(). Can you confirm that works as well?

Yes it works at install time. Not sure if it is also fine for update.php. Patch attached.

Patch at #12 works for me, thanks.

Although, fb_devel module has the same problem.

patch at #12 worked for me too

Planning to push this shortly. Thanks all.

Sorry, I got lost in duplicate issues. Fixed under #1182190: hook_custom_theme sometimes isn't called resulting in fatal error