Closed (fixed)
Project:
Webform
Version:
7.x-4.0-alpha6
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
1 Jan 2011 at 11:10 UTC
Updated:
1 Feb 2013 at 22:31 UTC
I have disabled all webform permissions for everyone (so only the superuser has access). However, as soon as I log in with another user and view my form, the "webform" tab shows up at the top and the user can change, or even delete the form. The user I've logged in with has permission to edit nodes, but they should not be able to access the webform tab on the form I've created, only the "edit" tab!
Comments
Comment #1
thequestess commentedScratch that, I don't think they should be able to even see the "edit" tab unless I select that they can edit webforms. Users with absolutely no webform permissions should not be able to do anything but view a webform.
Comment #2
quicksketchWebform uses the existing "Edit" permissions to grant access to the "Webform" tab. You should see the Webform tab whenever you can see the Edit tab.
If you're seeing the "Edit" tab as any authenticated user, you probably have a permission misconfigured (maybe you've granted users "Administer nodes" permission?)
Comment #3
thequestess commentedYes, the "authetnicated user" had been granted the "administer nodes" permission.
This seems like a huge design flaw. I can enable or disable the editing or deleting of other types of nodes (e.g. Page, Story), even though those users have "administer nodes" permissions. This allows me to grant edit access to certain areas of the site, but not others. For example, I might want to allow one person to post in the blog, and another person to update our links page. But, just because I give a user one type of edit access does not mean that they should have free access to everything!
I don't want to share webforms access because I don't want my contributors to break them, plain and simple. This interface is a bit complicated, and beyond that, the other contributors have no reason to be editing web forms. Usually you only give access on an as-needed basis, but the way permissions are set up for webforms seems to contradict this.
It's a really neat module, but this is a huge concern for people running websites with multiple contributors.
Furthermore, the permissions we're presented with are confusing if it all comes down to "administer nodes."
Why present the option "user can edit webforms" or "user can delete webforms" when unchecking them does not prevent that user from doing these things?
If I have "administer nodes" enabled, the user can edit webforms regardless of what settings I give to the webforms-specific permission. If I have "administer nodes" disabled, the user can't edit the webforms at all; it's pointless.
Comment #4
quicksketchGranting users "administer nodes" is a gross misconfiguration of your site. You should realize that makes it so that any authenticated user can delete ALL the content on your entire site! Drupal does not provide separate permissions for editing and deleting nodes if they have administer nodes permission. "administer nodes" will allow all content to be edited and deleted regardless of any other permissions. Webform does not provide "user can edit webforms" because node.module already provides "edit any webform content" permission. However, that permission makes no difference on your site because you've granted "administer nodes" permission, which overrides all other node permissions.
Comment #5
quicksketchComment #6
scriptaimago commentedHi quicksketch, great work by the way!
It seems to me that is not only a question if granting "administer nodes" privileges.
Lets say I configure a new content type called "layout".
In "webform settings" I enable "layout" as a Webform-enabled content type.
I give permission to a specific role "ROLE" to be able:
- TO edit and create "layout",
- NOT TO create or edit (do nothing) in any webform in the user permission zone.
well the problem is that the "ROLE" user can still see the webform tab, create and edit the webform inside the layout content type.
Any idea?
Comment #7
gynekolog commentedSolution for 7 version -> http://drupal.org/node/1025724#comment-6205060
Comment #8
quicksketch