Closed (fixed)
Project:
Megamenu
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Jan 2011 at 14:14 UTC
Updated:
7 Feb 2011 at 21:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
zazinteractive commentedWould like a Drupal 7 version
Comment #2
novakov commentedsame to me
Comment #3
Anonymous (not verified) commentedThe tentative plan is to port the beta release to 7 (7.x-1.x). After a full 6.x release, a new 7.x branch will start (7.x-2.x), which will incorporate any architectural changes and will be the release for all new features moving forward.
Comment #4
KirstenLangholz commentedThanks for letting us know. At least there is hope...
Comment #5
novakov commentedin marinelli theme for D7 megamenu is build in
Comment #6
KirstenLangholz commentedThanks for this information. Maybe I can port it from there...
Comment #7
Anonymous (not verified) commentedThanks to sylv3st3r, we have a D7 port. We'll look into testing this soon.
Comment #8
bladwin commentedI would like to see a D7 port. I would also be willing to test as well. Florida Drupal camp is in two weeks (http://fldrupalcamp.org), we would like to use this for the recipient of our "Coding for a Cause" event this year. The central Florida Computer Society (http://www.cfcs.org) currently has a complex navigation system, so for the rebuild, we think that this module would be a great addition. FLDC's beginner track will be showcasing D7 and the presenters will be building the new CFCS website, as part of their presentation, for the following day's Coding event. For more info, visit the FLDC site or contact me directly. I'd really like to help with getting a D7 release of this module!
Comment #9
Anonymous (not verified) commentedI haven't had a chance to review sylv3st3r's port, but I'm posting it here to crowd source the testing. He basically ported the latest 6.x-2.x-dev snapshot, so it is close to the 6.x-2.x beta.
Comment #10
dbkern commentedI am trying the port in #9 but upon enabling, I get the following messages:
Notice: Undefined variable: menus in _megamenu_enabled_menus() (line 35 of xxxxx/sites/all/modules/megamenu/megamenu.utilities.inc).
Notice: Undefined variable: blocks in megamenu_block_info() (line 124 of xxxx/sites/all/modules/megamenu/megamenu.module).
Warning: Invalid argument supplied for foreach() in _block_rehash() (line 386 of xxxx/modules/block/block.module).
Notice: Undefined variable: menus in _megamenu_enabled_menus() (line 35 of xxxxx/sites/all/modules/megamenu/megamenu.utilities.inc).
Notice: Undefined variable: blocks in megamenu_block_info() (line 124 of xxxx/sites/all/modules/megamenu/megamenu.module).
Warning: Invalid argument supplied for foreach() in _block_rehash() (line 386 of xxxxx/modules/block/block.module).
Comment #11
sylv3st3r commentedAdded a check for empty menu on _megamenu_enabled_menus() eg:upon first installing the module, the megamenu table is still empty.
Please try attached version
Comment #12
dbkern commentedThanks sylv3st3r! Will try #11.
Uninstalled #9, installed and enabled #11. The undefined variable notices went away but I still have warnings re the block module:
Warning: Invalid argument supplied for foreach() in _block_rehash() (line 386 of xxxx/modules/block/block.module).
Warning: Invalid argument supplied for foreach() in _block_rehash() (line 386 of xxxxx/modules/block/block.module).
Comment #13
sylv3st3r commentedHum, this is due the fact that if there is no enabled megamenu blocks upon installation and so hook_block_info returns nothing. Which causing that errors. At this point I'm out of option by using the original code.
Actually I was thinking to change megamenu block work flow like this :
1. There will be 1 block defined at the minimum to contain the megamenu.
2. More block can be added by megamenu settings.
3. Each of megamenu block have a setting of which menu they represent to
4. With each block have it's own settings, we can add more options. Like custom CSS for the block(inline or from file), custom class, etc.
But I merely help port this module to Drupal 7. Not making a new version of it :P I need the owner permission right.
That block warning aside. I'm more interested if the port works? If it's not a fatal errors, please continue on.
Comment #14
Anonymous (not verified) commentedIf it basically works, then we'll create a dev branch so you can start contributing patches like that.
Comment #15
dbkern commentedWhen I implement the block in the header I get this:
Fatal error: [] operator not supported for strings in xxxx/includes/common.inc on line 2313
When I return to admin/structure/block I get this:
Notice: Undefined variable: twig_items_list in megamenu_theme_menu_tree() (line 310 of xxxx/sites/all/modules/megamenu/megamenu.module).
Does not appear functional
Comment #16
sylv3st3r commentedOk.... so I fed up. The truth is. I don't test the module much before. Because I'm too lazy to create another virtual host with a clean D7 installation :hammer:. So.... I created it this time. Using menu on README as an example.
Sorry for the wait. I have my own real job, the one with money~ :wink:
This should work now. Please try. Thanks.
Comment #17
Anonymous (not verified) commentedThank you so much for spending your spare time working on this. If you have a Paypal tip jar I'll send you some beer money :-)
Comment #18
sylv3st3r commentedEuh, by saying I have to do my real job and money doesn't mean I want money from this~
I love that I can contribute to the community... but if you insist, I wouldn't say no to kindness :P
Comment #19
sylv3st3r commentedSorry for another change.
Added #991952: Configurable JS Options
So now you can set the default timeout for all menus from the configuration page. No need to hardcore anymore.
PS to maintainer : You can use this method to D6 too
Comment #20
Tim Jones Toronto commentedThanks for your work sylv3st3r on this D7 port :) I am testing this module and will report back (it installs on a clean installation and will test with other modules/themes).
I agree with your points #13 to remove the _block_rehash() error. Maybe in .install to create a simple Taxonomy called 'MegaMenu1' and assign to a 'header' block (depending on theme installed). Or another idea to set by default to 'Main menu' and assign a block of header of content that can later be changed by the user?
What are your views FilmKnurd also (thanks for the work too, also line 30 in .install has spelling wrong: 'dissabled' to 'disabled' :P).
Cheers
Tim
Comment #21
Tim Jones Toronto commentedHere are my test updates installed on fresh D7 install:
1. Rearranging some of the Terms in Taxonomy around (adding) for more tests I got an error:
Notice: Undefined variable: leaf_items_list in megamenu_theme_menu_tree() (line 289 of U:\xampp\htdocs\sites\all\modules\megamenu\megamenu.module).
It doesn’t break the site however.
2. Orientations: When changing from horizontal to vertical, it keeps the horizontal orientation (I cleared caches etc.). The 'Slot Orientation' option works fine and other options from this form work.
3. The menus show thru the admin overlay of Drupal 7.
Cheers.
Comment #22
Anonymous (not verified) commentedTim, I like the idea of providing a main menu mega out of the box from a UX perspective. That's probably the most popular menu to megatize. Thanks for your testing.
Sylv3st3r, I know you aren't begging for money, but if you were local I'd take you out for a beer :-)
Comment #23
Tim Jones Toronto commentedFilmKnurd, yes, it's coming together nicely in the main.
Will continue to test versions.
Comment #24
Anonymous (not verified) commentedI just loaded it up on a fresh D7 install and it seems to be working. I think it is at least good enough to get a dev branch going. Then we can create separate issues for it (block notice on install, no menu access to module configuration, etc.)
Comment #25
Tim Jones Toronto commentedGreat!
Comment #26
dbkern commentedHaving noticed that Tim was having success with this on a fresh install, I revisited implementing again. I used #19. I now have it working. I had two in-process ports of the Twitter and Oauth modules installed but not enabled that I also uninstalled/deleted them. Don't know if it was those modules that were in conflict or something with the previous version of this port.
Comment #27
dbkern commentedWent back and tested #11 again to see if the problem was related to the Twitter and Oauth modules. #11 has a fatal error even without the Twitter and Oauth modules. Reinstalled #19 and it works great. Thanks!
Comment #28
Tim Jones Toronto commentedGlad it's working!
I’m finding there is still some ironing out with all things Drupal 7 (on modules etc), but all part of the 'birthing process' for a new generation system :)
Comment #29
erykmynn commentedWe're going to move this into the repository today hopefully.
Comment #30
sylv3st3r commentedWow. Going off-grid for the weekend and I see 10 new comments. You guys never sleep eh?
I'll test out the vertical/ horizontal things soon, when I'm available, got some spam-going-pass-captcha issues *sigh* (I got 250 notification emails this morning, all spam).
The menus show thru the admin overlay of Drupal 7. => Ok I admit I disabled overlay (never liked it) Probably CSS (which I'm not really good at) But I'll look over it too.
But at least. So glad that it works for all of you.
Thanks to point-out .install mistake and leaf_item_list variable.
And thanks to all who test this. dbkern, who make me can't sleep because I keep thinking the bug (not blaming you, it just me). And Tim who bring the good news. And of course to the maintainer of this module.
Ok, so when ver.7 branch start working. Please close this and lets move to the new beginning.
And I'm afraid I'm not a local. @Indonesia here, haha. But I still love the beers, so feel free if you want (gunawan.roy@gmail.com : beer coin collector by Paypal :P). No pressure, really there's isn't such a thing :D
Edit : Found out the horizontal/ vertical problem :
Change the $slot_orientation to $menu_orientation (should be around line 340 @megamenu.module). Sorry, my bad :P
Comment #31
Anonymous (not verified) commentedErykmynn created the 7.x-1.x branch today. Now we're just waiting on the packaging script before the snapshot shows up on the project page. But, you can check out the 7.x branch via CVS.