Preliminary support for 5.x : PATCH

ullgren, will you be upgrading the module to 5.x? Is this how you would like help in proceeding, or are we missing something? I use webform on several sites and I love it. I would really like to be as helpful in possible in the upgrade.

I'll put in some effort to port webform to Drupal 5 soon. I'm quite busy at the moment though, so patches are very appreciated for the upgrade. Please keep any patches focused only on upgrading, and actually make them patches :-)

Here is the same update in patch form. I'll be testing it out tomorrow and repost with my status.

This is a patch to 4.7.x-1.x-dev : 2006-Nov-13

Looks as if the updates performed are not working out too well.

I'll run through patching 4.7.4-dev to 5 by following the http://drupal.org/node/64279 guide.

I'll also look over the changes made by pr0f3t to make sure I don't miss anything.

harking thanks for your patch. Today's the day for webform 5 upgrade. Can you provide the patch in the unified format (add -u flag to the diff)? My utilities for patch comparison (Eclipse) only uses unified formated patches. Check http://drupal.org/diffandpatch for more details.

Hi Guys,

I'm a total module newbie, but I need this module ready for 5.0 asap. If there's anything I can do to help please let me know.

Harking and I have this module nearly ready for 5.0. It's very, very close. You can download the HEAD release for functional operation, though there are still problems with viewing and deleting submissions.

@harking Let me know if you need any help finishing this up. I'm waiting to see what else you've put together.

Thanks!

Cobrasound sent me a list of more updates needed to webform before it is fully Drupal 5 ready. I've corrected all these problems and committed them back to CVS. I also branched the module for Drupal 5. Anyone interested in trying out the module for Drupal 5 should use the DRUPAL-5 branch (not HEAD) as this is where I'll continue the Drupal 5 porting process (if any more changes are necessary).

As patches go, this one probably isn't done 100% right, but the information is all there. I'll post the zipped up code in the next post so you can just use that if you'd like. I've tested it pretty thoroughly, fixed a few bugs that I encountered, and took advantage of some of the new Drupal 5 functionality. I originally replaced all of the $_POST values with form_values, but ran into issues, so if someone would like to address that, please go ahead. This should work as is.

And the files as source.

csevb10, thanks for the contribution. This patch is hard to follow because it's so huge. It looks like it removes the entire webform.module and replaces an entirely different version. Maybe there's a change in tabs or spaces that causes this?

Anyway, most of the changes needed for Drupal 5 are already in place, but there is no release yet created. You should use cvs to checkout the latest DRUPAL-5 branch as the archive files haven't yet been updated. http://www.lullabot.com/articles/cvs_quick_reference might help you checkout the module.

As for removing $_POST references... you're very right. We should be using form_values (in both Drupal 5 and 4.7 really). Let's put that in another patch after we get webform working on Drupal 5.

I'll take a look at the Drupal 5 release. If there's anything that was missed in that release that I did, I'll submit it again.
I'm using SVN & Eclipse, so maybe some aspect of that caused my patch to get all buggy...haven't really patched files before, so bear with me. :-)

This is a patch for the 5.x release. It corrects the following issues:
- unset variable warning
- webform_link formatting
- add the description to the top of the form page
- fix a missing variable issue for webform_client_form_add_component
Hopefully this one is actually useful. :-)

csevb10, thanks for the awesome patch. I can't tell you how much it helps to have another set of eyes on the code. I'd already gotten to a few of the issues, but I hadn't found:

- unset variable warning (This affected webform 4.7 also, nice!)
- fix a missing variable issue for webform_client_form_add_component

All the changes are now up in CVS. Post if you find anything else, the patches are very appreciated. Thanks!

Webform is now fully 5 compatible as far as my testing has shown. Please create separate issues for any new problems with webform under 5.x.