Punctuation in link breaks url

Will work on a patch. Thanks for filing.

This turns out to be an interesting bug (I think). I'm using the l function to generate the URL. That function passes the URL, in this case, reading-room?tid=11, to the url function. The url function escapes query strings and expects them to be passed separately as an options arguments.

The fact that the string escape is happening on the api level makes this a challenge. I'll need to seek some advice on how best to handle this use case. For now, i'll leave this ticket open as I would like to resolve this issue.

@madmatter23 as a quick work around, specify an absolute URL and it will by pass the string escaping.

@ngmaloney Yeah, that's exactly what's happening in l(). I've run into similar problems when having modules link to solr which specifies facets in the query string.

There are 2 options that come to mind for dealing with this.
1) just split the path on ? and use the first part as the path for l(). This would probably fail if there was and fragment though so you'd have to special case that as well.
2) use parse_url() to break up the url and then reform it into arguments to l(). You'll need to add extra logic or just bypass the parse_url() logic for absolute urls though.

Postponed. Need maintainer for D6 branch.

sorry wrong forum

I'm no longer actively maintaining the Drupal 6 version of the block_titlelink module except for critical and security related bugs. I'll gladly grant contrib access or release an update if anyone wishes to roll a patch.

Can someone confirm whether this is still a problem in the 6.x-2.0 branch?

I checked now in git and for the 6.x-2.x its not fixed.
It IS fixed in latest git for 7.x - so go in there on line 146 and migrate/backport the changes into 6.x

If someone wants to provide a patch to get this into the Drupal 6 version I'll get that rolled in. It seems like an easy win so I've added the novice tag.

Created a patch, hope it is the correct thing to do.

Sorry forgot to change the version. Patch is against the 6.x-2.0.

Does the problem also exists in D7 version? Can we get some more feedback on the patch?

Confirming that D7 version does NOT have this issue anymore.

This is outdated and is not supported anymore.