Posted by AntoineSolutions on January 3, 2011 at 8:22pm
2 followers
| Project: | UC Payflow Pro |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
When processing a single payment, this module:
- Calls uc_order_load three times.
- Passes the entire $order object 6 times.
uc_order_load should be called once and a reference to the order object should be passed.
Cheers,
Antoine
Comments
#1
A patch is attached that also has some code cleanup per http://drupal.org/coding-standards.
Cheers,
Antoine
#2
Changing priority to minor, since nothing is broken and it shouldn't have a significant performance impact (I'm pretty sure $order is static cached anyway). I'll still go over it when I get a chance.