At some point the dependency system was modified and modules that where missing .info files began making blank entries in the "Other" category on the module page. This one line patch fixes this by not adding the dependency element to the info array when we didn't get anything from the info file.

Marking RTBC due to the trivial nature of the fix.

CommentFileSizeAuthor
#5 module_info.patch803 bytesChrisKennedy
#2 hide_missing_info.patch_0.txt561 bytesneclimdul
hide_missing_info.patch.txt898 bytesneclimdul

Comments

ChrisKennedy’s picture

ChrisKennedy commented
Status: Reviewed & tested by the community » Needs work

The patch has a bunch of html junk at the top and bottom.

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new hide_missing_info.patch_0.txt561 bytes

That's what I get for copying a patch from a remote PC through IE. That'd be why I never use windows... Never touching windows again! (I wish)

Correct patch attached.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs work » Reviewed & tested by the community

Oh and status...

dww’s picture

dww
we/he/they
commented
Priority: Critical » Normal

critical? please. ;) this doesn't utterly break your site, so it's not critical...
that said, the patch looks reasonable. haven't tested, but i don't doubt it's RTBC.

ChrisKennedy’s picture

ChrisKennedy commented
StatusFileSize
new module_info.patch803 bytes

Oops, I duplicated this issue and came up with a patch. What about this doing it this way? It allows more .info logic to be added in the future.

http://drupal.org/node/88030 was the problem issue btw.

neclimdul’s picture

neclimdul
He/Him
commented

+1 to Chris' patch. That's probably a better way to do it and it hints to later people how to add add .info logic without revisiting this bug :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)