The problem is that HTML5 themes tend to use the <article> tag for blocks rather than <div>, and context's CSS and JS expect blocks always to be divs.

CommentFileSizeAuthor
#5 1013920-context-html5-support.patch9.37 KBmrfelton
#4 context_reaction_block.css_.txt4.06 KBkaido.toomingas
#4 context_reaction_block.js_.txt14.71 KBkaido.toomingas
#1 context.1013920.patch5.51 KBadamdicarlo

Comments

adamdicarlo’s picture

adamdicarlo commented
StatusFileSize
new context.1013920.patch5.51 KB

Here's a patch that fixes the problem.

I've tested this on a subtheme of boron_zen, and on a non-HTML5 theme (a Zen sub-sub-theme).

This patch makes the selectors a bit looser. The changes:

  • div.block → .block
  • div.admin-block → .admin-block
  • div.draggable → .draggable

div.draggable-placeholder is untouched, as I believe the div there is generated by context.

Is it safe to loosen these selectors? I can't see why not; when would .block be applied to something that isn't a block? And if .block is applied to something else, maybe it should be targeted by context's CSS & JS anyway.

Thoughts?

adamdicarlo’s picture

adamdicarlo commented
Status: Active » Needs review
adamdicarlo’s picture

adamdicarlo commented

See also #1017718: Node and block hovering doesn't happen in HTML5 themes for contextual module.

kaido.toomingas’s picture

kaido.toomingas commented
StatusFileSize
new context_reaction_block.js_.txt14.71 KB
new context_reaction_block.css_.txt4.06 KB

Thanks.. I used allmost the same with drupal 7 version.

mrfelton’s picture

mrfelton commented
StatusFileSize
new 1013920-context-html5-support.patch9.37 KB

Same problem using the Omega HTML 5 theme which uses <section> to markup blocks. Attached is a patch with the changes from #4. Works for me.

mrfelton’s picture

mrfelton commented
Version: 6.x-3.0 » 7.x-3.x-dev

Patch in #5 is for Drupal 7. I'm bumping the version number for this issue to 7.x-3.x-dev under the assumption that development work is taking place for D7 first, and then being backported.

agileware’s picture

agileware commented
Priority: Normal » Major

This issue is going to become more and more of an issue and there doesn't seem to be doco on the project page or readme in the inline context editing requirements that blocks must be wrapped in div.block

I have tried the patch in #5 and it seems to work but I have issues with a views slideshow block.
However I also have intermittent problems with views slideshow blocks when using blocks with div.block too so maybe that is unrelated.

muschpusch’s picture

muschpusch commented
Status: Needs review » Reviewed & tested by the community

i can confirm that the patch the works.

adamdicarlo’s picture

adamdicarlo commented

Do the patches need to be updated to support comments, too? (Do HTML5 themes use a new tag for comments?) When I originally wrote the patch it was on a site without comments.

febbraro’s picture

febbraro commented
Status: Reviewed & tested by the community » Patch (to be ported)

Sweet, thanks for this.

http://drupalcode.org/project/context.git/commit/f8daf81

hefox, marking port in case you want this for D6.

febbraro’s picture

febbraro commented
Version: 7.x-3.x-dev » 6.x-3.x-dev

  • mrfelton authored f8daf81 on 8.x-4.x 
    Issue #1013920 by mrfelton, muschpusch, kaido24: Make context ui...

  • mrfelton authored f8daf81 on 8.x-0.x 
    Issue #1013920 by mrfelton, muschpusch, kaido24: Make context ui...

  • mrfelton authored f8daf81 on 8.x-1.x 
    Issue #1013920 by mrfelton, muschpusch, kaido24: Make context ui...
deaom’s picture

deaom commented
Issue summary: View changes
Status: Patch (to be ported) » Closed (outdated)