im certain the title doesnt accurately describe the problem but from what i notice looking only at the output the forum navigation

tags are gone with class = forum-topic-navigation

i had to disable the module but its really helpful so i hope this can be resolved shortly. great work and thanks

Comments

Robrecht Jacques’s picture

Sorry, this is a bit cryptic. Could you elaborate?

Eg: when I enable forum and nodewords, when I go to the url XXX, there is no YYY.

Thanks

wdrupal100’s picture

When reading a forum topic node there is a

tag with class id "forum-topic-navigation" that provides links to the previous and next forum items. For my personal use I have this block set to "display: none".

However after I enable nodewords and browse to read the forum node again the

tag is gone and the next and previous links are placed immediately at the end of whatever content the forum topic had. Because the
tag is gone I am unable to control the display of the forum topic navigation.

I hope this helps. If not just reply. I like this module a lot and would like to see it working correctly.

Thanks!

Robrecht Jacques’s picture

I can't reproduce this.

If I go to a forum topic I can see the following in the HTML source:

<div class="forum-topic-navigation"><a href="/drupal/47/node/5" class="topic-previous" title="Go to previous forum topic">‹ Another test topic</a> <a href="/drupal/47/node/2" class="topic-next" title="Go to next forum topic">Nodewords and forum test ›</a><br class="clear" /></div></div>

The same thing appears whether I enable nodewords or not. If I understand you correctly, in your case this class="forum-topic-navigation" disappears, right? I really have no idea how nodewords.module would cause forum.module to omit that ???

This is on Drupal 4.7.4, latest nodewords.

wdrupal100’s picture

Hello,

You are exactly correct in diagnosing my problem. Sucks that you cant replicate it however. I guess I will try it one more time and try to get more information on what might be causing it. Maybe a conflict with another module but I have no idea why/how. I didnt have much time when I submitted the bug to look at the code but I will and update you as I know more.

If this helps here is my current information via the system info module:

Version 4.7.4
Sites directory default

Type Apache
Version 2.2.2
PHP Interface Module
Modules
mod_rewrite Loaded

Version 5.1.4
Magic Quotes GPC Off
Magic Quotes Runtime Off
Memory Limit
Register Globals Off
Safe Mode Off
Session Cache Limiter none
Session Save Handler user
Upload Max Filesize 8M
Extensions
CURL Support Disabled
GD Version bundled (2.0.28 compatible)
FreeType Support Enabled
XML Support Enabled
Zip Support Disabled
Zlib Support Enabled

Type MySQL
Version 4.1.20-community-nt
Charset utf8
Collation utf8_general_ci
Permissions
Create Temporary Tables Disallowed
Lock Tables Disallowed

Thanks!

Robrecht Jacques’s picture

That all looks ok.

Could you post the list of module you have enabled?

Robrecht Jacques’s picture

Status: Active » Postponed (maintainer needs more info)

I'll need a list of enabled modules before I can fix this (or at least find the reason why this may disappear).

cscsteve’s picture

I'm sure this is related since my issue relates to the same nav tags. Hence, not opening a new issue.

I post a forum topic. I go back and edit it and after the text I entered I end up with:
<div class="forum-topic-navigation"><a href="/p/node/195" class="topic-previous" title="Go to previous forum topic">‹ post by admin using default theme</a> <a href="/p/node/193" class="topic-next" title="Go to next forum topic">How do I post a Sealed project? ›</a></div>

(exact links, titles, etc are dependent on what is adjacent to the forum topic).

I go and disable nodewords, go back to edit the same forum topic and the topic nav code is no longer there.
Enable nodwords, it comes back.

nodewords-4.7.x-1.2

I was able to disable almost all non required modules and simply switching nodewords on and off shows the issue.
enabled modules:
comment
forum
oradrup
taxonomy

I've managed to track it down to line 783 in function _nodewords_prepare():

      case 'node':
        $node = node_load($ids[0]);
        if ($node && node_access('view', $node)) {
          // HACK: see http://drupal.org/node/79315 (can't use php functions in
          // body of nodes).
          $cachable = filter_format_allowcache($node->format);
          if ($cachable) {
            // HACK: see http://drupal.org/node/89067 (teaser as description with
            // [inline] error).
            if (node_hook($node, 'view')) {
              node_invoke($node, 'view', TRUE);
            }
            else {
              $node = node_prepare($node, TRUE);
            }
            node_invoke_nodeapi($node, 'view', TRUE);
            $tags['description'] = $node->teaser;
          }
        }
        break; 

at the node_invoke($node, 'view', TRUE); call.

It calls the forum_view() hook. If you replace the theme_forum_topic_navigation() function to return empty, the problem goes away. Doing so is fine in our case since we don't want the prev/next nav anyway, so the work-around is fine, but it looks like the HACK is causing an interesting issue.

Also of note: I wasn't able to reproduce this on a different dev box I have. I've noted a number of problems when I'm developing modules and moving them from the dev box to the client's QA box, all related to the fact that I'm running PHP 4 and the QA box is running PHP 5.

I hope this gives you a clue on how to fix it.

Thanks,
- Steve

avpaderno’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

Version 4.7-x-1.x-dev is not supported anymore; I am closing this report.