I am testing D7 RC4 and Mollom 7.x from 22-Dec-2010.

I deleted the keys that were previously working fine and saved my settings. Even with empty text box fields for the keys I keep seeing this message:

"Mollom servers verified your keys. The services are operating correctly."

It seems to be a minor issue, but could reflect a larger problem around config settings...might be worth a look.

CommentFileSizeAuthor
#7 mollom.remove-keys.7.patch1.55 KBsun
#1 mollom-HEAD.remove-keys.1.patch1.23 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Priority: Normal » Minor
Status: Active » Needs review
StatusFileSize
new mollom-HEAD.remove-keys.1.patch1.23 KB

Let's start with a test.

Status: Needs review » Needs work

The last submitted patch, mollom-HEAD.remove-keys.1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

#1: mollom-HEAD.remove-keys.1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, mollom-HEAD.remove-keys.1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

#1: mollom-HEAD.remove-keys.1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, mollom-HEAD.remove-keys.1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new mollom.remove-keys.7.patch1.55 KB

So, indeed, when both keys are deleted, key validation is never performed.

Attached patch fixes the issue. Test-only patch was in #1 and proved the bug.

dries’s picture

dries commented

This patch is RTBC and can be committed as soon as the test bot comes back with a green light (currently in the state 'test request sent').

Status: Reviewed & tested by the community » Needs work

The last submitted patch, mollom.remove-keys.7.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

#7: mollom.remove-keys.7.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit f92f803 on master, fai6, 8.x-2.x, fbajs, actions by sun: 
    Issue #1014148 by bdunwood, sun: Fixed keys are not re-verified after...

  • Commit f92f803 on master, fai6, 8.x-2.x, fbajs, actions by sun: 
    Issue #1014148 by bdunwood, sun: Fixed keys are not re-verified after...