Posted by Jay Daverth on January 4, 2011 at 8:57pm
2 followers
Jump to:
| Project: | Flickr Rippr |
| Version: | 6.x-6.x-dev |
| Component: | Flickr Rippr Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
Not sure if this is a bug or a feature request. I have changed the workflow for the content type to promote to front page, but still must do this manually for all new imported flickr images.
Comments
#1
Changing this to a bug since it is reproducing. As these hard-coded sets are no longer part of the code (am now on the dev version), there is no obvious reason for the override. Also, this is applying to comment settings as well (content is set to read/write but all imports are set to disabled).
#2
With regard to the previous, I can also confirm that even when the node settings are manually overridden to allow comments, new comments are not being downloaded (despite log messages to the contrary).
Not to be snarky, but it has been almost four weeks since this was posted - is this module being maintained?
#3
It's maintained -- but life is busy this month.
Can you clarify if you're seeing this bug with flickr comment importing, or only with drupal comments? What does the node record look like the in node table for newly imported photos?
The module doesn't currently set any comment or other workflow settings on the node object, as per a patch on a previous issue.
#4
No worries, mate. Again, didn't know how to ask without sounding snarky!
As far as comments go, drupal comments are fine. I also do indeed get the log message that it is "going to get" comments, but even though the images have comments on flickr they are not being imported as drupal comments. The node record for the most recent fetch is:
nid - 1500
vid - 1502
type - flickrrippr_photo
language -
title - 38/365:2011
uid - 1
status - 1
created - 1297089151
changed - 1297109360
comment - 0
promote - 0
moderate - 0
sticky - 0
tnid - 0
translate - 0
As far as the 0 status on comments/promotion, I saw that patch you mentioned go through (and have the updated code) so I see no reason why this should happen. For the record, I also see nothing whatsoever in your code that would cause this. That said, I have manually ensured that the flickrrippr content type is set to allow comments and promote to front page, yet each time I run cron (and download a new image) I have to still manually override.
#5
i'm seeing the same in my testing.
I'm away at foo camp this weekend, so will have probably look at this the weekend after.
#6
i'm not going to be able to respond to this for many weeks, due to the earthquake -- patches welcome, and i can give out commit access to anyone keen to fix this.