Not able to have result entered by team manager

Hi Onno, thanks for your post, I am really busy at the moment, and not had time to check this out, but the feature worked for me when I tested it and implemented it, so it should work, as long as the user you are trying to edit with is a "thymosfloorballcaptain"
I will have a look at the code when I can to resolve this.
Thanks
Alun

Confirmed that it doesn't work.

HI guys, i'm sorry for the late reply on this, I just had a quick look at the code and I realised I have not done this.
There is a comment on line 154 of leaguesite_match.module pointing this out!
I am not on a computer where I can test this, but I think the following changes need to be made..

on line 142, the database query needs to be changed to the following:

  $result = db_query("SELECT home_team.uid AS home_owner, away_team.uid AS away_owner, home_team.manager AS home_manager, away_team.manager as away_manager FROM {leaguesite_match} match LEFT JOIN {leaguesite_team} home_team ON match.home_team = home_team.nid LEFT JOIN {leaguesite_team} away_team ON match.away_team = away_team.nid WHERE {node}.type='leaguesite_team' AND {leaguesite_match}.nid = %d", $node->nid);

This should get the managers UID as well as the node owners.
Then we need to update the if statement on line 155 to check all these possible owners.

change it from

if(user_access('enter results for your teams leaguesite_match', $account) && ($account->uid == $row['uid'])){
return TRUE;
}

to this:

//check the managers first
if(user_access('enter results for your teams leaguesite_match', $account) && (($account->uid == $row['home_manager']) || ($account->uid == $row['away_manager']))){
return TRUE;
}
//and now check the node owners
if(user_access('edit own leaguesite_match', $account) && (($account->uid == $row['home_owner']) || ($account->uid == $row['away_owner'])){
return TRUE;
}

That should be along the lines of what needs to be done. Apologies for not having this done sooner. Let me know how it goes. As soon as I get a chance to sort this on my local installation (it doesn't happen often!) I'll make sure it works and commit it.
Thanks
Alun

EDIT: Please be kind with syntax errors if any occur, I typed this off the top of my head into this textbox :-)

Here the patch.

Where do you have this error OnnoRoos ? (which page)

If i can give you an advice, if you need a version with new features always use dev, a known bug is with the integration with brackets (the integration isn't in alpha 4), if you don't use this you can i think safely choose the dev version.

Hi again OnnoRoos !

Ok something is definitevely wrong with this :

$result = db_query("SELECT home_team.uid AS home_owner, away_team.uid AS away_owner, home_team.manager AS home_manager, away_team.manager as away_manager FROM {leaguesite_match} match LEFT JOIN {leaguesite_team} home_team ON match.home_team = home_team.nid LEFT JOIN {leaguesite_team} away_team ON match.away_team = away_team.nid WHERE {node}.type='leaguesite_team' AND {leaguesite_match}.nid = %d", $node->nid);

Alun could you give a feedback about this request?

But i think it's not just one error in the syntax but many, tell me if i am wrong about this.

Sorry the SQL query was a bit off the mark

$result = db_query("SELECT home_team_node.uid AS home_owner, away_team_node.uid AS away_owner, home_team.manager AS home_manager, away_team.manager as away_manager FROM leaguesite_match LEFT JOIN leaguesite_team home_team ON leaguesite_match.home_team = home_team.team_id LEFT JOIN leaguesite_team away_team ON leaguesite_match.away_team = away_team.team_id LEFT JOIN node home_team_node ON home_team.team_id = home_team_node.nid LEFT JOIN node away_team_node ON away_team.team_id = away_team_node.nid WHERE leaguesite_match.nid = %d", $node->nid);

Should be the right one, at least it throws no syntax errors!

Hi Alun!

Here the new patch :)

PS :

Did you see my last post here : http://drupal.org/node/776932 ?

It seems to be working on the alpha4 version, so here is a patch. I'll get one for the dev version - haven't quite figured out the git thing yet!!
Alun

And here is the dev version!

Hi Onno,
The match admin screen should be the way they can see all of their matches that they can edit.
Thanks
Alun