Ron --

Thanks for all your hard work in developing and maintaining this great bibliography module.

Today, in preparation for upgrading another module to D7, I turned on STRICT and NOTICE PHP messaging for the first time in an age. As a result, I got a few messages about minor issues with this module. I will create separate issues for each item as I resolve them locally and thus give you a chance to update the D7/D6 code base appropriately.

The first issue I resolved has to do with the variable $inline in the theme_biblio_author_link() function on approximately line 572. The code in question is:

$inline = $inline ? "/inline" : "";

The problem is that on the right side of the assignment $inline has not yet been initialized. I added a line above initializing this to zero. I suspect that the longer term solution is to pass $inline to the function as an optional parameter set to a default NULL or FALSE value. However, I will leave it to you as to what you think is best. The variable does need to be initialized to some value to eliminate the NOTICE message. Thanks!

Cheers!

CommentFileSizeAuthor
#1 biblio_undefined_inline_var.patch467 byteshchonov

Comments

hchonov’s picture

Version: 6.x-1.15 » 6.x-1.18
Issue summary: View changes
StatusFileSize
new467 bytes

fixed temporarily by first checking if $inline is set.
attached patch

liam morland’s picture

Status: Active » Closed (outdated)

This version is no longer maintained. If this issue is still relevant to the Drupal 7 version, please re-open and provide details.