Another small issue showing up with PHP NOTICES turned on concerns the use of the $output variable on approximately line 53 of biblio_style_classic.inc file in the biblio_style_classic() function. There is a possibility that line 53

$output .= '';

is executed without having entered the if statement just above. Hence, the variable $output can be in an uninitialized state. Adding $output= ""; just above the if statement removes this condition and hence the NOTICE statement.

Cheers!

Comments

ch1mjw’s picture

Same error shows in clean install of D7:

Notice: Undefined variable: output in biblio_style_classic() (line 53 of /---path---/drupal7/sites/all/modules/biblio/styles/biblio_style_classic.inc).

rjerome’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.