Nodequeue is working fine, but any time that I attempt to use Apache Solr, I get the following error:

Warning: Missing argument 3 for nodequeue_apachesolr_modify_query(), called in /var/www/sites/all/modules/apachesolr/apachesolr.module on line 1514 and defined in nodequeue_apachesolr_modify_query() (line 408 of /var/www/sites/all/modules/nodequeue/nodequeue.module).

Apache Solr does return a proper result set.

For the time being I just commented out the Solr hook.

CommentFileSizeAuthor
#5 1015104-missing_argument_3_for_nodequeue_apachesolr_modify_query.patch1.05 KBamateescu
#4 nodequeue-missing-argument3-1015104-4.patch1.06 KBkeithm
#3 nodequeue-missing-argument3-1015104-3.patch1.03 KBsetvik
#2 nodequeue-apachesolor-1015104-2.patch1 KBbrenk28

Comments

ezra-g’s picture

ezra-g commented
Title: Apache Solr » Missing argument 3 for nodequeue_apachesolr_modify_query()

Seems we need to update per #1007860: API fix for hook_apachesolr_modify_query. Thanks for the report :) !

brenk28’s picture

brenk28 commented
StatusFileSize
new nodequeue-apachesolor-1015104-2.patch1 KB

Here is an attempt for a patch.

setvik’s picture

setvik commented
Status: Active » Needs review
StatusFileSize
new nodequeue-missing-argument3-1015104-3.patch1.03 KB

Sweet! Thanks for the patch. Worked great.

Added in the class hint (DrupalSolrQueryInterface) and rerolled the patch

keithm’s picture

keithm commented
StatusFileSize
new nodequeue-missing-argument3-1015104-4.patch1.06 KB

Applying #3 produced another warning, this time on argument 2. Added default to fix it.

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 1015104-missing_argument_3_for_nodequeue_apachesolr_modify_query.patch1.05 KB

Tested this and it's ready to fly :)

Rerolled #4 because it applied with an offset.

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Commited to 7.x. Thanks!

http://drupalcode.org/project/nodequeue.git/commit/9aa3dd9

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.