I want my subthemes to inherit skins defined in the base theme, but I am not sure how to do this in 7.x-2.x-dev, is it even possible? I've been reading through the various discussions and I suppose I am either missing something or the functionality is missing?

CommentFileSizeAuthor
#10 skinr-HEAD.basetheme.10.patch3.56 KBsun
#9 skinr-HEAD.basetheme.9.patch3.56 KBsun
#7 skinr-HEAD.basetheme.7.patch5.22 KBsun
#6 skinr-HEAD.basetheme.6.patch1.05 KBsun
#4 normal-themes.patch1.11 KBjacine
#2 skinr-HEAD.test-themes.2.patch1.16 KBsun

Comments

moonray’s picture

moonray commented

See #977118: Skins in disabled basetheme cannot be enabled for basetheme (to appear in subtheme) for more details.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Category: support » task
StatusFileSize
new skinr-HEAD.test-themes.2.patch1.16 KB

First of all, we need to commit attached patch.

jacine’s picture

jacine
she/her
Location New York
commented

Ok, committed. I've also got this patch applied locally so that running tests will be possible:

#953336: Contributed modules are not able to test theme-related functionality

jacine’s picture

jacine
she/her
Location New York
commented
Status: Active » Needs review
StatusFileSize
new normal-themes.patch1.11 KB

Here's some normal themes.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Active

Committed #4: http://drupal.org/cvs?commit=482384

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new skinr-HEAD.basetheme.6.patch1.05 KB

Alright, so here's the dirty quick-fix we discussed. Contains a @todo for the proper fix, which will require some mind-boggling array iteration logic, but doable.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new skinr-HEAD.basetheme.7.patch5.22 KB

Proper fix, including tests. :)

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Active

#7 is in:

http://drupal.org/cvs?commit=482442
http://drupal.org/cvs?commit=482478

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new skinr-HEAD.basetheme.9.patch3.56 KB

Couldn't stand that we have incomplete/insufficient tests here (not testing that skins of other/disabled themes are not collected). ;)

This patch or #1028334: Change the "default_status" property to "default status" needs to be re-rolled for the 'default status' change, whichever lands first. Re-rolling the other should be easier though, as this one adds new files.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new skinr-HEAD.basetheme.10.patch3.56 KB

Re-rolled against HEAD.

jacine’s picture

jacine
she/her
Location New York
commented

Should this also test for (and maybe prevent) this situation? #1028948-1: Skins don't appear to be loading multiple javascript (and possibly CSS) files

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Nope, the tests in this patch are focused on this issue. Tests for that issue are going to happen in that issue.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Active

#10 is in.

http://drupal.org/cvs?commit=483058

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed

This issue is effectively going to be fixed via #977118: Skins in disabled basetheme cannot be enabled for basetheme (to appear in subtheme)

Not marking as duplicate, because some patches have been committed here.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.