Closed (outdated)
Project:
Corolla
Version:
6.x-1.20
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Jan 2011 at 18:41 UTC
Updated:
29 Feb 2016 at 00:30 UTC
Jump to comment: Most recent
If you make a sub-theme of Corolla and save any non-default setting on theme settings page for that sub-theme, it is saved correctly, but theme-settings.php is loading back the parent Corolla settings and not the saved one.
I think the problem arises with bugfix in 6.20 core #481142: Theme settings forms are not inherited by sub-themes where you don't have to copy theme-settings.php for sub-themes any more.
The line #21 in theme-settings.php should be modified to:
$settings = array_merge($defaults, $saved_settings);
Comments
Comment #1
zirvap commentedI won't claim to understand the code, but I can confirm this behaviour and that the patch fixes this issue.
What I did to test:
I have a subtheme of Corolla. I change the teme settings for the subtheme. I then go to admin/build/themes/settings/corolla (but don't save anything there), and return to admin/build/themes/settings/mysubtheme. The settings on the subtheme page now are similar to the ones on the Corolla page, but the site still looks as if the changed settings are effective.
When do the change described in the first post and do the same test, the settings for my subtheme stay the same.
Comment #2
Jeff Burnz commented