Do not prefix actions in the xmlrpc server

By removing the prefix of all three we're risking collisions - but I guess that is okay. Fact is we're already risking collisions as services_controller_get() and services_controllers_list() apparently already works this way (but with the order: 'actions', 'relationships', 'targeted actions'). So I guess actions isn't working at all in XML-RPC right now? Moving to critical.

Since services_controller_get() and services_controllers_list() and _xmlrpc_server_resources_as_procedures() deals with the same functionality I wonder why they have been split up between two modules? I think that either _xmlrpc_server_resources_as_procedures() should be moved out of the XML-RPC module or services_controller_get() and services_controllers_list() should be moved in to it. Considering we've a lot of RPC-style third party servers for Services 2.x I think we should move _xmlrpc_server_resources_as_procedures() out of the XML-RPC module to make methods for converting resources into RPC-methods available for them.

Also - to consistently resolve collisions I think we should define a order of precedence. Most resources wont be constructed with RPC in mind so it's quite important to solve collisions correctly I think. This is what services_controller_get() does today - it's probably the best:

Crud methods > Actions > Relations > Targeted Actions

I think we should move _xmlrpc_server_resources_as_procedures() as part of this issue as well as ensuring that it handles collisions in a good consistent way.

Just looking at the code it seems like a good patch - except for:

+++ services.module	15 Jan 2011 18:21:45 -0000
@@ -512,3 +512,55 @@ function services_controller_get($name, 
+    'method' => $resource .'.'. $name,

There should be some spaces between the . and ' ;)

+++ servers/xmlrpc_server/xmlrpc_server.module	15 Jan 2011 18:21:45 -0000
@@ -43,7 +44,7 @@ function xmlrpc_server_xmlrpc() {
-      foreach (_xmlrpc_server_resources_as_procedures($def) as $method) {
+      foreach (services_resources_as_procedures($def) as $method) {
         $callbacks[$method['method']] = 'xmlrpc_server_call_wrapper';
       }

The order of precedence is not preserved here - right? Either we need to reverse the loop or we need to check that the method hasn't actually been set.

Powered by Dreditor.

@ygerasimov: Do you test that order of precedence is correct?

A test resource sounds reasonable I think.

@heyrocker: Did you fix my feedback in #7?