Roles not set correctly on user Import

After some digging and a fair bit of trial and error, I discovered the solution. The underlying problem appeared to be the entries in th array of roles expected by the account object. Each entry in the array must itself have been an array of role_id=>role_name.

Because I had set up my roles beforehand and because my source data contains role_name's, I needed to to map my role_names to role_id's before constructing a list. I did this in three steps:

1. Create a field to hold a map of role_id's to role_names
   

   class MyMigration extends Migration {
   
     public $role_name_id_map;
   
   

2. Create a map of role_name's to role_id's in the Migration's constructor:
   

   public function __construct() {
     // . . .Other Logic. . .
       $role_arr = user_roles(true);
       foreach($role_arr as $rid=>$rname){
         //print("ID($rid)=NAME($rname)\n");
         $this->role_name_id_map[$rname] = $rid;    
       }
   }
   

3. Set up the field mapping
   

       $this->addFieldMapping('roles', 'subscr_role')->separator(',');
   

4. In the prepare function convert the array of role_names from the mapping to an array of role_id=>role_name arrays.
   

     public function prepare(stdClass $account, stdClass $row) {
   
       $roles = array();
       if( isset($account->roles) ){
         foreach ($account->roles as $role){
           $rid = $this->role_name_id_map[$role];
           //print("User $account->name has role='$role' rid='$rid'\n");
           if( isset($rid) )
             $roles[$rid] = $role;
           else print("User $account->name has Unrecognized role='$role'\n");
         }
       }
       $account->roles=$roles;
     }
   

I don't know if this is something that should be added to the user import plugin. If it is, and someone points me in the right direction, I could try to create a patch at will handle this...