When a user enters a number for a role limit which is lower than the number of users already in the role, Role Limits should report "You cannot enter a limit which is less than the number of registered users in the @role role" - Instead, the following error appears:

Notice: Undefined variable: form_values in role_limits_admin_settings_validate() (line 130 of /Users/kennys/Sites/drupal7/sites/all/modules/role_limits/role_limits.module).

The value is also saved. Working on a patch now to fix this issue.

CommentFileSizeAuthor
#1 1017100-validation-fix.patch1.13 KBwebkenny

Comments

webkenny’s picture

webkenny commented
Assigned: Unassigned » webkenny
Status: Active » Needs review
StatusFileSize
new 1017100-validation-fix.patch1.13 KB

The attached patch corrects some legacy code that crept it's way in from the Drupal 5 version of the module. Fixes the validation error noted above. Has been committed to 7.x-1.x-DEV which has not been packaged yet.

webkenny’s picture

webkenny commented
Status: Needs review » Reviewed & tested by the community

Patch so far seems to work on my install pretty flawless. I'll roll this into a release next week.

webkenny’s picture

webkenny commented
Priority: Critical » Major
Status: Reviewed & tested by the community » Closed (fixed)