option to cache image_get_info [#1017820]

Just did a cachegrind and getimagesize() took 1,093ms for 8 calls. I'm using memcache so if we were to store this info in a cache_imagecache bin I'm guessing that would be quicker. image_get_info() is where this PHP function is called, so I'm proposing having cache_get/set be in theme_imagecache().

Thoughts? Create my own module and overwrite this theme function? Preprocess function?

files dir is a S3 mount thus its a little bit slower.

Comment	File	Size	Author
#4	imageinfo_cache.tar_.gz	875 bytes	mikeytown2
#3	imageinfo_cache.tar_.gz	872 bytes	mikeytown2

Comments

Comment #1

mikeytown2 commented 7 January 2011 at 01:11

hook_theme_registry_alter seems to be the answer I was looking for.

function imageinfo_cache_theme_registry_alter(&$theme_registry) {
  if (isset($theme_registry['imagecache'])) {
    variable_set('imageinfo_cache_theme_imagecache_function', $theme_registry['imagecache']['function']);
    $theme_registry['imagecache']['function'] = 'imageinfo_cache_theme_imagecache';
  }
}

function imageinfo_cache_theme_imagecache() {
  $args = func_get_args();

  // Use cached data if available
  $path = imagecache_create_path($args[0], $args[1]);
  $cid = md5($path);
  $image = cache_get($cid, 'cache_imageinfo');
  if ($image) {
    $image = $image->data;
  }
  else {
    $image = image_get_info($path);
    // Cache for 24 hours
    cache_set($cid, $image, 'cache_imageinfo', time() + (60 * 60 * 24));
  }
  if ($image) {
    $attributes['width'] = $image['width'];
    $attributes['height'] = $image['height'];
    $args[4] = array_merge($args[4], $attributes);
    $args[5] = FALSE;
  }

  // Run original function
  $function = variable_get('imageinfo_cache_theme_imagecache_function', 'theme_imagecache');
  call_user_func_array($function, $args);
}

This something you want or should I put it in a new module called imageinfo_cache?