Nofollowlist was one of the modules I needed for a client that wants to switch to drupal-7.x now.

So I ported it.
I'm not a maintainer of this module so I can only attach my final result.

All changes I made (CHANGELOG.txt):

- Ported to drupal-7.x with coder-7.x-1.x-dev 2010-12-31.
- Added CHANGELOG.txt.
- Changed "nofollowlist" to "NofollowList" in all titles and descriptions for better readability.
- Added code-tag around ref="nofollow" to descriptions for better readability.
- #982362: removed <p>-tag from filter-description so drupal-theming-standards are full respected.
- Added .install-file so variables and entries in the filter-table get deleted upon uninstallation.
CommentFileSizeAuthor
#19 1017964-d7-port-19.patch7.84 KBc31ck
#16 1017964-d7-port-16.patch26.32 KBc31ck
#15 portnofollowlisttoD7-1017964-15.patch23.92 KBjibran
#14 portnofollowlisttoD7-1017964-14.patch7.65 KBjibran
nofollowlist-7.x-1.x-dev 2010-01-06 r2-d8.tar_.gz7.63 KBR2-D8

Comments

svenryen’s picture

svenryen commented

Thanks a lot for your work! Just a minor detail - 2010 in your file name looks a bit out of place.
At first I wondered if your code was 1 year old ;)

R2-D8’s picture

R2-D8 commented

Oh sorry - this is happening still every morning and every late night ;)
I'm just working too much.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Fixed » Active
ajayg’s picture

ajayg commented
Status: Active » Needs review

Any further update on this?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Active

I am waiting for someone to post a patch. I don't review tarballs :(

R2-D8’s picture

R2-D8 commented

Are you joking?
I've ported this module half a year ago for FREE and you did nothing because it's a tarball????????
I'm totally shocked. How about patching it yourself??

- The module is ready to use.
- Check the new elements (first off: changelog)
- Get it online.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Selfmade port to 7.x » Port nofollowlist to 7.x
Priority: Major » Normal

I'm not joking. The Drupal project works on patches. That's why we have a page very high in our navigation for http://drupal.org/patch/create

Note that it doesn't say "How to do your work and make a tarball" it says "How to do your work and make a patch."

basicmagic.net’s picture

basicmagic.net commented

subscribe

MGParisi’s picture

MGParisi commented

http://www.seomoz.org/blog/google-says-yes-you-can-still-sculpt-pagerank...

Kinda interesting, sounds like nofollow is dead.

Z2222’s picture

Z2222 commented

@R2-D8: thanks for the update to D7.

I would generate the patch if I knew how. This is an important module that should be integrated into core, since it's bad for SEO to nofollow internal links on user-generated content. This module is a better way to nofollow links than Drupal's core input filters since you can whitelist the internal links on UGC.

ressa’s picture

ressa
he/him
commented

@ J. Cohen: Here are a few guides on how to patch a module. It would be greatly appreciated by the Drupal community if you patch the Nofollow List module :-)

Z2222’s picture

Z2222 commented

I would, but I've had only 3 days off from work in the past few months and I barely have a free moment. I don't even get much sleep at the moment. Maybe I'll have time to relearn it in January when things quiet down. :)

ressa’s picture

ressa
he/him
commented

I totally understand, remember to take care of yourself :-)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new portnofollowlisttoD7-1017964-14.patch7.65 KB

I have created a patch from above tarball. I just wanted to help. This is not at all my code.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new portnofollowlisttoD7-1017964-15.patch23.92 KB

Sorry, I forgot to include new files here is updated patch.

c31ck’s picture

c31ck commented
StatusFileSize
new 1017964-d7-port-16.patch26.32 KB

Patch against master branch that ports this module to D7. Based largely R2-D8's work, but I added in wildcard support for hosts and made some other small changes here and there.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

It's worth noting #1415992: Offering to maintain Nofollow List.

IMO a patch to port from 6.x to 7.x should just do the port and not add features.

c31ck’s picture

c31ck commented
Status: Needs review » Needs work

Ok, lets limit this issue to porting to D7 and let's refrain from doing code cleanup and adding features here. We can tackle those in separate issues after we have opened up a 7.x branch.

c31ck’s picture

c31ck commented
Status: Needs work » Needs review
StatusFileSize
new 1017964-d7-port-19.patch7.84 KB

New patch that contains only the port to D7 and does not add any new features.

wmostrey’s picture

wmostrey commented

The patch in #19 provides a clean upgrade to Drupal 7 and it works as expected. As far as I'm concerned it's RTBC.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

@wmostry - thanks for the review. The module is currently marked as abandoned. I no longer use it and Ryan Szrama (the other maintainer) doesn't either.

So, @c31k or @wmostrey if you are interested in maintaining the module please let me know and I can make the change.

c31ck’s picture

c31ck commented

@greggles I'm interested in maintaining this module: #1415992: Offering to maintain Nofollow List

c31ck’s picture

c31ck commented
Status: Needs review » Reviewed & tested by the community

Setting status to RTBC based on #20.

c31ck’s picture

c31ck commented
Status: Reviewed & tested by the community » Fixed

Created a 7.x-1.x branch and created #1437700: Add .install file.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.