Download & Extend
Issues

Provide node type/bundle in comment_entity_info()

Posted by sun on January 7, 2011 at 1:43am
Project:Drupal core
Version:7.x-dev
Component:comment.module
Category:task
Priority:normal
Assigned:sun
Status:closed (fixed)
Issue tags:needs backport to D7, Quick fix

Issue Summary

Copying from admin_menu.map.inc:

            // @todo Make Comment module expose the original node type bundle,
            //   pretty please.
            if (drupal_substr($bundle_name, 0, 13) == 'comment_node_') {
              $bundle_name = drupal_substr($bundle_name, 13);
            }
AttachmentSizeStatusTest resultOperations
drupal.comment-node-bundle.0.patch951 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal.comment-node-bundle.0.patch. See the log in the details link for more information.View details
Login or register to post comments

Comments

#1

Posted by sun on January 13, 2011 at 1:27pm

drupal.comment-node-bundle.0.patch queued for re-testing.

#2

Posted by dixon_ on September 2, 2011 at 9:24am
Version:7.x-dev» 8.x-dev

#3

Posted by sun on September 2, 2011 at 1:52pm

#4

Posted by sun on September 2, 2011 at 1:52pm

drupal.comment-node-bundle.0.patch queued for re-testing.

#5

Posted by System Message on September 2, 2011 at 2:47pm
Status:needs review» needs work

The last submitted patch, drupal.comment-node-bundle.0.patch, failed testing.

#6

Posted by sun on September 2, 2011 at 2:50pm
Status:needs work» needs review

Re-rolled against latest branch head.

AttachmentSizeStatusTest resultOperations
drupal8.comment-node-bundle.6.patch776 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 32,915 pass(es).View details

#7

Posted by dixon_ on September 2, 2011 at 3:44pm
Status:needs review» reviewed & tested by the community

To me this looks like a sensible addition. The patch is very simple, and looks good to me.

#8

Posted by dixon_ on September 2, 2011 at 3:46pm

The patch applies without offset to D7. So should be ready for straight backport.

#9

Posted by catch on September 28, 2011 at 6:40am
Version:8.x-dev» 7.x-dev

Looks good to me as well, I'm pretty sure I've had to figure out the node type back from the comment before as well.

Committed to 8.x, moving to 7.x for webchick to consider.

#10

Posted by webchick on September 30, 2011 at 8:07pm
Status:reviewed & tested by the community» fixed

This seems like a pretty harmless and convenient API addition. I'm comfortable committing to 7.x as well.

Committed/pushed. Thanks!

#11

Posted by System Message on October 14, 2011 at 8:11pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.