Closed (fixed)
Project:
Location Map
Version:
7.x-1.0
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Jan 2011 at 13:29 UTC
Updated:
30 Sep 2011 at 00:18 UTC
Jump to comment: Most recent file
Comments
Comment #1
babbage commentedYes, I just recently identified this myself. Out of interest, were you using gmaplocation in Drupal 6, because my quick initial testing suggested that perhaps that code was already broken in D6... though I need to test that further.
Comment #2
mpicinich commentedI get the same error when saving my block. My block never shows up at all.
Comment #3
pazap47 commentedJust tried the module and get the same warning. This is a new install no upgrade. THXS
Comment #4
Carlos Miranda Levy commentedSame error here. Clean 7 install.
Saving the block configuration generates the error, even if you don't add text to be shown above.
But at least the title and path to display at are saved. It appears to be just the value of the text to be shown above that's not saved and generates the error.
Comment #5
Ganganation commentedSame problem as comment #4
@attachement - text you see above the image is not from the locationmap block
Comment #6
babbage commentedGiven other commitments, it is unlikely I'll be fixing this before the May-July timeframe. Patches welcome.
Comment #7
xlyz commentedhere is a patch that fix this bug and add block image width and height configuration on top.
Comment #8
nikolino commentedGreat work!
But I have a problem ...
I set the width to 900px but the image is not larger than 640px.
Does anyone know why?
Comment #9
babbage commentedxlyz, thank you for your patch. I have literally not seen this till now, due to commitments that have kept me away from d.o completely. Apologies for the delay; I hope to test and commit this in the next couple of days.
Comment #10
xlyz commentedno prob. attribution appreciated.
Comment #11
nathancollins44 commentedI am getting this error also.
Notice: Undefined index: locationmap_text_top in locationmap_block_save() (line 355 of /home8/kpcprodu/public_html/americanwrc/sites/all/modules/locationmap/locationmap.module).I don't have any text in the block "Additional text to show above the image " area...
I do have a block title and I also have a "WYSIWYG CK editor" in the "Additional text"
Do I need to do anything about this Notice? The map and all seems to be functioning properly, and I don't need any additional text to show above the image for now... maybe I'll just wait for the next module release and hope it fixes the problem?
Comment #12
nathancollins44 commentedYay I just installed my first drupal module patch ever!
You know what, I just went ahead and forced myself to just do the patch.
Problem is fixed and I can also change the size of the map in the block area.
Yay I did it I'm so proud of myself. :-D
Comment #13
babbage commentednathancollins44: well done. next step, write a patch! :)
Watch this space...
Comment #14
babbage commentedCommitted in fdd7c38.
Attribution given as requested xlyz. Always happy to do this, though I may forget. I suggest you use git format-patch so that your authorship metadata is included in your patch files and thus automatically applied. See http://drupal.org/node/1146430
Comment #15
babbage commentedAnd we're done.
Comment #16
babbage commentedxlyz: just a point. When introducing a new configuration option, it's important to make sure that the default value is the same as the previous hard-coded value, so that the upgrade doesn't break previous site layouts. I'll correct that in the next commit.
Comment #17
xlyz commentedyep. i did take note of that already, but too late for this patch. ty btw.
Comment #19
tamsoftware commentedPatch applied and tested here too.
Works great, thanks!
Franck Horlaville
TAM Software