site-install fails for d6 when using a site alias

I'll try to reorganize above report:

1/ drush @alias si doesn't work *for d6* because of the alias (it doesn't matter the cwd --in $drupal_root or out). I've succesfully run the same command for d7.
2/ mysql -v is inadequate if you plan to parse its result.
3/ db_query() is called by drush_sql_drop() and is not available before DRUSH_BOOTSTRAP_DRUPAL_DATABASE

My alias is:

$aliases['imc'] = array (
  'root' => '/var/www/imc',
  'uri' => 'http://imc',
  'databases' => 
  array (
    'default' => 
    array (
      'default' => 
      array (
        'driver' => 'mysql',
        'username' => 'root',
        'port' => '',
        'host' => 'localhost',
        'database' => 'drupal_imc',
      ),
    ),
  ),
);

and the original site was installed at sites/default. There's no multisite environment. So I run drush @imc si.

The first chunk of code to be run through php -r in site_install_6.inc is:

Executing: php -r 'error_reporting(E_ERROR);$_GET=array("profile"=>"default", "locale"=>"en", "id"=>"1"); $_REQUEST=&$_GET;define("DRUSH_SITE_INSTALL6", TRUE);$_SERVER["SERVER_SOFTWARE"] = NULL;$_SERVER["SCRIPT_NAME"] = "/install.php";$_SERVER["HTTP_HOST"] = "http://imc";$_SERVER["REMOTE_ADDR"] = "127.0.0.1";function _cli_cookie_print(){print(serialize(array(session_name()=>session_id())));}
register_shutdown_function("_cli_cookie_print"); include("/var/www/imc/install.php");'
  a:1:{s:9:"PHPSESSID";s:0:"";}

The difference when running si from the drupal root is that $_SERVER["HTTP_HOST"] = "http://imc" is always the same as --sites-subdir, and without http://.

Attached a patch that fix this situation and doesn't seem to break other scenarios.

btw here's the debug output:

jonhattan@jengibre:~$ drush @imc si --debug
You are about to DROP your 'imc' database and then CREATE a new one. Do you want to continue? (y/n): y
Sites directory sites/default already exists - proceeding. [4.36 sec, 7.34 MB]                                        [notice]
Calling system(mysql --database=information_schema --host=localhost --user=root --password=root  < /tmp/phpNWhEML);
Executing: php -r 'error_reporting(E_ERROR);$_GET=array("profile"=>"default", "locale"=>"en", "id"=>"1"); $_REQUEST=&$_GET;define("DRUSH_SITE_INSTALL6", TRUE);$_SERVER["SERVER_SOFTWARE"] = NULL;$_SERVER["SCRIPT_NAME"] = "/install.php";$_SERVER["HTTP_HOST"] = "http://imc";$_SERVER["REMOTE_ADDR"] = "127.0.0.1";function _cli_cookie_print(){print(serialize(array(session_name()=>session_id())));}
register_shutdown_function("_cli_cookie_print"); include("/var/www/imc/install.php");'
  a:1:{s:9:"PHPSESSID";s:0:"";}
Executing: php -r '$_GET=array("profile"=>"default", "locale"=>"en", "id"=>"1"); $_REQUEST=&$_GET;define("DRUSH_SITE_INSTALL6", TRUE);$_SERVER["SERVER_SOFTWARE"] = NULL;$_SERVER["SCRIPT_NAME"] = "/install.php";$_SERVER["HTTP_HOST"] = "http://imc";$_SERVER["REMOTE_ADDR"] = "127.0.0.1";$_COOKIE=unserialize("a:1:{s:9:\"PHPSESSID\";s:0:\"\";}"); $_GET["op"]="start"; include("/var/www/imc/install.php");'
Executing: php -r '$_GET=array("profile"=>"default", "locale"=>"en", "id"=>"1"); $_REQUEST=&$_GET;define("DRUSH_SITE_INSTALL6", TRUE);$_SERVER["SERVER_SOFTWARE"] = NULL;$_SERVER["SCRIPT_NAME"] = "/install.php";$_SERVER["HTTP_HOST"] = "http://imc";$_SERVER["REMOTE_ADDR"] = "127.0.0.1";$_COOKIE=unserialize("a:1:{s:9:\"PHPSESSID\";s:0:\"\";}"); $_GET["op"]="do_nojs"; include("/var/www/imc/install.php");'
Executing: php -r '$_GET=array("profile"=>"default", "locale"=>"en", "id"=>"1"); $_REQUEST=&$_GET;define("DRUSH_SITE_INSTALL6", TRUE);$_SERVER["SERVER_SOFTWARE"] = NULL;$_SERVER["SCRIPT_NAME"] = "/install.php";$_SERVER["HTTP_HOST"] = "http://imc";$_SERVER["REMOTE_ADDR"] = "127.0.0.1";$_COOKIE=unserialize("a:1:{s:9:\"PHPSESSID\";s:0:\"\";}"); $_GET["op"]="finished"; include("/var/www/imc/install.php");'
Executing: php -r '$_GET=array("profile"=>"default", "locale"=>"en", "id"=>"1"); $_REQUEST=&$_GET;define("DRUSH_SITE_INSTALL6", TRUE);$_SERVER["SERVER_SOFTWARE"] = NULL;$_SERVER["SCRIPT_NAME"] = "/install.php";$_SERVER["HTTP_HOST"] = "http://imc";$_SERVER["REMOTE_ADDR"] = "127.0.0.1";$_COOKIE=unserialize("a:1:{s:9:\"PHPSESSID\";s:0:\"\";}");
  $_POST = array (
    "site_name" => "Site-Install", 
    "site_mail" => "admin@example.com", 
    "account" => array (
      "name" => "admin",
      "mail" => "admin@example.com",
      "pass" => array (
        "pass1" => "admin",
        "pass2" => "admin"
      )
    ),
    "date_default_timezone"=>"0", 
    "clean_url"=>1,
    "form_id"=>"install_configure_form", 
    "update_status_module" => array("1"=>"1")
  );
  include("/var/www/imc/install.php");'
Command dispatch complete [4.94 sec, 7.35 MB]                                                                         [notice]
 Timer  Cum (sec)  Count  Avg (msec) 
 page   4.381      1      4381.43    

Peak memory usage was 7.4 MB [4.95 sec, 7.35 MB]                                                                      [memory]

Although it doesn't mark an error it doesn't install the site at all.

The problem here has introduced by me in #1004476: site-install doesn't work for d6 when installing in a subdir. HTTP_HOST should not include the protocol part. drupal_valid_http_host() in conf_init() was killing the installation process.

I'm not able to install a site at sites/mixedCase site even via web. mixedCase is supposed to be a domain name and they're case insensitive. I see my browser and apache lowercasing it.

With attached patch we force to assign mixedCase to HTTP_HOST, and also pass the failure to drupal internals. No possible fix IMO.

In the log:

Executing: php -r 'error_reporting(E_ERROR);$_GET=array("profile"=>"default", "locale"=>"en", "id"=>"1"); $_REQUEST=&$_GET;def
ine("DRUSH_SITE_INSTALL6", TRUE);$_SERVER["SERVER_SOFTWARE"] = NULL;$_SERVER["SCRIPT_NAME"] = "/install.php";$_SERVER["HTTP_HO
ST"] = "mixedCase";$_SERVER["REMOTE_ADDR"] = "127.0.0.1";function _cli_cookie_print(){print(serialize(array(session_name()=>se
ssion_id())));}

....

        <div id="center"><div id="squeeze"><div class="right-corner"><div class="left-corner">
            <h2>Requirements problem</h2>                    <h3>The following error must be resolved before you can continue the installation process:</h3><div class="messages error">
  The Drupal installer requires that you create a settings file as part of the installation process.
  <ol>
  <li>Copy the <em>./sites/default/default.settings.php</em> file to <em>./sites/default/settings.php</em>.</li>

The patch is syntactically precise in the usage of 'uri' (by respecting http://) so commited. Also implemented a validation callback to force lowercase sites-subdir.

http://drupal.org/cvs?commit=495602

Backport #18 worth it to reduce some possible bug reporting. Attached the complete patch.