Download & Extend

Update Media: Webcam for d7

Project:Media: Webcam
Version:7.x-1.x-dev
Component:Miscellaneous
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

On the way. This will add a new widget to core file fields, and a new tab to the Media browser...

Comments

#1

subscribing

#2

subscribing

#3

Component:Code» Miscellaneous

subscribing

#4

Sweet! Subscribe

#5

Subscribing
I've got a project where this is needed and are willing to pitch in with development.
Ping me via contact form/irc if you're interested.
LR

#6

tracking

#7

sub

#8

I've got the port for this done.
Patch attached, also requires a new sprite which goes in includes/theme/css/img.
In terms of playing, checkout flowplayer issue quere where I've attached a patch to add formatter support.

AttachmentSize
media_webcam-d7.patch 26.44 KB
sprite.png 14.3 KB

#9

Status:active» needs review

status

#10

update?

#11

working anyone?

#12

I am getting the error: This version is not compatible with Drupal 7.x and should be replaced.

#13

Version:6.x-1.x-dev» 7.x-1.0-beta2
Status:needs review» fixed

Committed that. Thanks, @larowlan!

#14

Status:fixed» needs work

crud. I need coffee. The patch didn't even apply...

#15

Yep same here...

#16

Aaron
Do you want me to send a tar.gz of the module?
Personally I hate it when people do that (I prefer a patch) so figured I'd ask first.

Lee

#17

@larowlan,

I also generally prefer a patch, but am not sure why this one didn't apply. Here is the output that I had, if anyone knows from that. Feel free to post a zip of the module if that's easier than troubleshooting the patch.

Thanks,
Aaron

$ git apply -v media_webcam-d7.patch
media_webcam-d7.patch:89: trailing whitespace.
  background-position: 0 -294px;
media_webcam-d7.patch:97: trailing whitespace.
  background-position: 0 -196px;
media_webcam-d7.patch:215: trailing whitespace.
 
media_webcam-d7.patch:239: trailing whitespace.
 
media_webcam-d7.patch:460: trailing whitespace.
 
Checking patch includes/media_webcam.admin.inc...
Checking patch includes/themes/css/img/camera.png...
error: cannot apply binary patch to 'includes/themes/css/img/camera.png' without full index line
error: includes/themes/css/img/camera.png: patch does not apply
Checking patch includes/themes/css/img/play-over.png...
error: cannot apply binary patch to 'includes/themes/css/img/play-over.png' without full index line
error: includes/themes/css/img/play-over.png: patch does not apply
Checking patch includes/themes/css/img/play.png...
error: cannot apply binary patch to 'includes/themes/css/img/play.png' without full index line
error: includes/themes/css/img/play.png: patch does not apply
Checking patch includes/themes/css/img/record-over.png...
error: cannot apply binary patch to 'includes/themes/css/img/record-over.png' without full index line
error: includes/themes/css/img/record-over.png: patch does not apply
Checking patch includes/themes/css/img/record.png...
error: cannot apply binary patch to 'includes/themes/css/img/record.png' without full index line
error: includes/themes/css/img/record.png: patch does not apply
Checking patch includes/themes/css/img/sprite.png...
error: cannot apply binary patch to 'includes/themes/css/img/sprite.png' without full index line
error: includes/themes/css/img/sprite.png: patch does not apply
Checking patch includes/themes/css/img/stop-disabled.png...
error: cannot apply binary patch to 'includes/themes/css/img/stop-disabled.png' without full index line
error: includes/themes/css/img/stop-disabled.png: patch does not apply
Checking patch includes/themes/css/img/stop-over.png...
error: cannot apply binary patch to 'includes/themes/css/img/stop-over.png' without full index line
error: includes/themes/css/img/stop-over.png: patch does not apply
Checking patch includes/themes/css/img/stop.png...
error: cannot apply binary patch to 'includes/themes/css/img/stop.png' without full index line
error: includes/themes/css/img/stop.png: patch does not apply
Checking patch includes/themes/css/media_webcam.css...
Checking patch includes/themes/js/media_webcam.js...
Checking patch includes/themes/media-webcam-widget.tpl.php...
Checking patch includes/themes/media_webcam.theme.inc...
Checking patch media_webcam.info...
Checking patch media_webcam.module...

#18

alternatively, I'm happy to add you as a co-maintainer of the module if you'd like :)

#19

Version:7.x-1.0-beta2» 7.x-1.x-dev

version change

#20

yeah happy to go co-maintainer - I know you've got a lot on both with Drupal and privately.
I tried to upload the module but it failed because of 3mb limit.
I will reroll the patch

#21

Here's the patch without the image stuff

AttachmentSize
media_webcam-d7.patch 24.61 KB

#22

Plus also found this in my repo (more changes post the above patch).
So this is in addition to the previous one.

AttachmentSize
media_webcam-d7-2.patch 3.45 KB

#23

Status:needs work» needs review

#24

larowlan,

You're a maintainer now. Feel free to commit your work to the 7.x-1.x branch, or I can take a look next week.

Thanks,
aaron

#25

Status:needs review» fixed

Have pushed my work.
Will test it with the package once your dev release is rolled.

#26

dev rolled out?

#27

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#28

when is the d7 version coming out?

nobody click here