Update Media: Webcam for d7 [#1019104]

Comment	File	Size	Author
#22	media_webcam-d7-2.patch	3.45 KB	larowlan
#21	media_webcam-d7.patch	24.61 KB	larowlan
#8	media_webcam-d7.patch	26.44 KB	larowlan
#8	sprite.png	14.3 KB	larowlan

Comment #1

sidharth_k commented 21 January 2011 at 20:22

subscribing

Log in or register to post comments

Comment #2

pragnatek commented 26 January 2011 at 12:51

subscribing

Log in or register to post comments

Comment #3

gcrouse commented 26 January 2011 at 14:50

Component:

Code

» Miscellaneous

subscribing

Log in or register to post comments

Comment #4

Anonymous (not verified) commented 6 July 2011 at 04:17

Sweet! Subscribe

Log in or register to post comments

Comment #5

larowlan

🇦🇺🏝.au GMT+10

commented 1 August 2011 at 00:56

Subscribing
I've got a project where this is needed and are willing to pitch in with development.
Ping me via contact form/irc if you're interested.
LR

Log in or register to post comments

Comment #6

mefisto75 commented 1 September 2011 at 05:53

tracking

Log in or register to post comments

Comment #7

BeaPower commented 23 September 2011 at 05:39

sub

Log in or register to post comments

Comment #8

larowlan

🇦🇺🏝.au GMT+10

commented 29 September 2011 at 12:17

Status	File	Size
new	sprite.png	14.3 KB
new	media_webcam-d7.patch	26.44 KB

I've got the port for this done.
Patch attached, also requires a new sprite which goes in includes/theme/css/img.
In terms of playing, checkout flowplayer issue quere where I've attached a patch to add formatter support.

Log in or register to post comments

Comment #9

larowlan

🇦🇺🏝.au GMT+10

commented 29 September 2011 at 12:17

Status:

Active

» Needs review

status

Log in or register to post comments

Comment #10

BeaPower commented 6 October 2011 at 15:36

update?

Log in or register to post comments

Comment #11

BeaPower commented 23 November 2011 at 16:01

working anyone?

Log in or register to post comments

Comment #12

BeaPower commented 23 November 2011 at 16:19

I am getting the error: This version is not compatible with Drupal 7.x and should be replaced.

Log in or register to post comments

Comment #13

aaron commented 23 November 2011 at 16:38

Version:	6.x-1.x-dev	» 7.x-1.0-beta2
Status:	Needs review	» Fixed

Committed that. Thanks, @larowlan!

Log in or register to post comments

Comment #14

aaron commented 23 November 2011 at 16:43

Status:

Fixed

» Needs work

crud. I need coffee. The patch didn't even apply...

Log in or register to post comments

Comment #15

BeaPower commented 23 November 2011 at 17:18

Yep same here...

Log in or register to post comments

Comment #16

larowlan

🇦🇺🏝.au GMT+10

commented 23 November 2011 at 20:57

Aaron
Do you want me to send a tar.gz of the module?
Personally I hate it when people do that (I prefer a patch) so figured I'd ask first.

Lee

Log in or register to post comments

Comment #17

aaron commented 23 November 2011 at 23:22

@larowlan,

I also generally prefer a patch, but am not sure why this one didn't apply. Here is the output that I had, if anyone knows from that. Feel free to post a zip of the module if that's easier than troubleshooting the patch.

Thanks,
Aaron

$ git apply -v media_webcam-d7.patch
media_webcam-d7.patch:89: trailing whitespace.
  background-position: 0 -294px; 
media_webcam-d7.patch:97: trailing whitespace.
  background-position: 0 -196px; 
media_webcam-d7.patch:215: trailing whitespace.
  
media_webcam-d7.patch:239: trailing whitespace.
  
media_webcam-d7.patch:460: trailing whitespace.
  
Checking patch includes/media_webcam.admin.inc...
Checking patch includes/themes/css/img/camera.png...
error: cannot apply binary patch to 'includes/themes/css/img/camera.png' without full index line
error: includes/themes/css/img/camera.png: patch does not apply
Checking patch includes/themes/css/img/play-over.png...
error: cannot apply binary patch to 'includes/themes/css/img/play-over.png' without full index line
error: includes/themes/css/img/play-over.png: patch does not apply
Checking patch includes/themes/css/img/play.png...
error: cannot apply binary patch to 'includes/themes/css/img/play.png' without full index line
error: includes/themes/css/img/play.png: patch does not apply
Checking patch includes/themes/css/img/record-over.png...
error: cannot apply binary patch to 'includes/themes/css/img/record-over.png' without full index line
error: includes/themes/css/img/record-over.png: patch does not apply
Checking patch includes/themes/css/img/record.png...
error: cannot apply binary patch to 'includes/themes/css/img/record.png' without full index line
error: includes/themes/css/img/record.png: patch does not apply
Checking patch includes/themes/css/img/sprite.png...
error: cannot apply binary patch to 'includes/themes/css/img/sprite.png' without full index line
error: includes/themes/css/img/sprite.png: patch does not apply
Checking patch includes/themes/css/img/stop-disabled.png...
error: cannot apply binary patch to 'includes/themes/css/img/stop-disabled.png' without full index line
error: includes/themes/css/img/stop-disabled.png: patch does not apply
Checking patch includes/themes/css/img/stop-over.png...
error: cannot apply binary patch to 'includes/themes/css/img/stop-over.png' without full index line
error: includes/themes/css/img/stop-over.png: patch does not apply
Checking patch includes/themes/css/img/stop.png...
error: cannot apply binary patch to 'includes/themes/css/img/stop.png' without full index line
error: includes/themes/css/img/stop.png: patch does not apply
Checking patch includes/themes/css/media_webcam.css...
Checking patch includes/themes/js/media_webcam.js...
Checking patch includes/themes/media-webcam-widget.tpl.php...
Checking patch includes/themes/media_webcam.theme.inc...
Checking patch media_webcam.info...
Checking patch media_webcam.module...

Log in or register to post comments

Comment #18

aaron commented 23 November 2011 at 23:23

alternatively, I'm happy to add you as a co-maintainer of the module if you'd like :)

Log in or register to post comments

Comment #19

aaron commented 23 November 2011 at 23:23

Version:

7.x-1.0-beta2

» 7.x-1.x-dev

version change

Log in or register to post comments

Comment #20

larowlan

🇦🇺🏝.au GMT+10

commented 23 November 2011 at 23:36

yeah happy to go co-maintainer - I know you've got a lot on both with Drupal and privately.
I tried to upload the module but it failed because of 3mb limit.
I will reroll the patch

Log in or register to post comments

Comment #21

larowlan

🇦🇺🏝.au GMT+10

commented 23 November 2011 at 23:43

Status	File	Size
new	media_webcam-d7.patch	24.61 KB

Here's the patch without the image stuff

Log in or register to post comments

Comment #22

larowlan

🇦🇺🏝.au GMT+10

commented 23 November 2011 at 23:44

Status	File	Size
new	media_webcam-d7-2.patch	3.45 KB

Plus also found this in my repo (more changes post the above patch).
So this is in addition to the previous one.

Log in or register to post comments

Comment #23

larowlan

🇦🇺🏝.au GMT+10

commented 23 November 2011 at 23:44

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #24

aaron commented 24 November 2011 at 01:32

larowlan,

You're a maintainer now. Feel free to commit your work to the 7.x-1.x branch, or I can take a look next week.

Thanks,
aaron

Log in or register to post comments

Comment #25

larowlan

🇦🇺🏝.au GMT+10

commented 24 November 2011 at 02:18

Status:

Needs review

» Fixed

Have pushed my work.
Will test it with the package once your dev release is rolled.

Log in or register to post comments

Comment #26

BeaPower commented 4 December 2011 at 19:32

dev rolled out?

Log in or register to post comments

Comment #27

18 December 2011 at 19:40

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #28

BeaPower commented 20 December 2011 at 04:50

when is the d7 version coming out?

Log in or register to post comments

Update Media: Webcam for d7

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

Comment #27

Comment #28

News items

Our community

Documentation

Drupal code base

Governance of community