Closed (fixed)
Project:
Sky
Version:
7.x-1.3
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Jan 2011 at 03:10 UTC
Updated:
7 Feb 2011 at 17:00 UTC
Hi these section are not opening
Toggle display
Logo image settings
Shortcut icon settings
on the theme setting
Also where do I put the logo ???? which folder?
anyways to fix that?
Comments
Comment #1
jacineOh man, I forgot to print the logo! I'll fix this in the next release shortly, but in the meantime, you can paste this code to replace the current code for the $site_name and $site_slogan:
Regarding the collapsible fieldsets, you are correct there is a problem. I wasn't aware of this because I was using the Color Theme module, which is highly recommended for configuring Sky's theme settings. You can download it here: http://drupal.org/project/colortheme. You'll be able to see open those fieldsets with this module installed and place the path to your logo in there.
Thanks for reporting these issues! I'll have fixes up shortly. :)
Comment #2
wallbay1 commentedThanks a lot mate it works ! :)
Comment #3
jacineA fix has been committed.
Comment #4
mehtatejas commentedHi,
I had installed drupal 7 , colortheme(1.0) and recent sky theme(1.2). Enable color theme module and enabled and set sky theme as default. Still I am facing the same issue.
i.e. following section are not opening on the theme setting.
-Toggle display
-Logo image settings
-Shortcut icon settings
Please guide me if I am missing something.
Comment #5
jacineIt should be working now, regardless of whether or not the color theme module is installed in 1.2.
What theme do you see when visiting the theme settings page?
What browser/OS are you using?
Are there any JavaScript errors on your page?
Comment #6
shunting commentedThe look: http://www.universalpantograph.com
I'm having the exact same problem as #4
On theme settings tabs I'm seeing bartik, garland, sky
FF, OS X Server 10.4.11
No JavaScript errors.
Also, if I scroll down the page, the color wheel floats along.
Comment #7
jacineThe color wheel floating along was done on purpose so that you can see the footer and preview area colors while applying them. I could do a better job with that though, I know. :)
I'm not sure what the deal is with those collapsible fieldsets. They are working just fine on my end. The only difference between my setup and yours is that I'm on OS X 10.6.6. I'm using Firefox 3.6.13. Since I can't reproduce this, any help trying to debug it would be appreciated.
In the meantime, you can disable JavaScript and they'll be expanded if you need to set the logo right now.
Comment #8
mehtatejas commentedOn theme settings tabs I'm seeing bartik, Seven, sky.
FF 3.6.13, Windows 7.
No JavaScript errors.
Also, the color wheel is 3/4th visible.
thanks by disabling Javascript, I am able to update logo
Comment #9
shunting commentedAh! Is there a way to stop the floating when it gets into the collapsible area? Or maybe it does, and I'm not seeing it now.
Is there a Jquery dependency that's not documented, maybe?
Thanks for the rapid response!
Comment #10
jacineI'm really not sure what the problem is because it's all working well here. I'm gonna see what I can do with the color wheel, and then you guys can test it, but I doubt that's the problem. Can you guys check to see if collapse.js is loading on that page for you? That's the only thing I can think of that would cause problems here.
Comment #11
shunting commentedI installed colortheme and added this to sky.info:
scripts[] = public_html/misc/collapse.js
and cleared my cache via devel, and collapse.js now appears when I view source, but the problem persists.
And disabling JavaScript in FF does make the collapsed items appear.
Comment #12
mehtatejas commentedYes you were right about collapse.js.
I copied collapse.js to theme js folder and added following code to sky.info.
scripts[] = js/collapse.js
Now I am able to see collapsible tabs.
Please do necessary changes in theme.
Thanks.
Comment #13
jacineVery strange that it loads by default for me and not you guys...
However, it doesn't belong in the .info file as that would make it load on all pages. Please try putting this code in color/color.inc and let me know if it fixes the problem for you. I'm unable to test this currently, as my site is loading the file already.
drupal_add_js('misc/collapse.js');Comment #14
jacineI've committed a fix for this and the color wheel. It will be in the next release.
http://drupal.org/cvs?commit=481790
http://drupal.org/cvs?commit=481788
Comment #15
jacineApparently this is still a problem on some times and I have no idea why, so I'm getting rid of the collapsible fieldsets in the next release.
I've committed the changes, but won't roll a release until this is confirmed by a few people. The changes will appear in the tarball in the next 12 hours, but you can see diff of the changes now here: http://drupal.org/cvs?commit=482348
Comment #16
mehtatejas commentedWith changes (7.x-1.3), color wheel is now standstill at the top. However toggle is not working. If I disable java-script, color wheel disappears and setting window appears and vice versa.
Comment #17
jacine@mehtatejas The code I committed is in the -dev release. Check that.
Comment #18
mehtatejas commentedThank you Jacine..
Dev release is working fine.
Comment #19
jacineThanks for testing @mehtatejas. I am going to have to assume that it's fine for everyone else.