"Privatemsg Rules Integrations" requires "Entity Metadata" (which is marked as deprecated...)

Error: Call to undefined function entity_metadata_get_properties() in
/sites/all/modules/privatemsg/privatemsg_rules/privatemsg_rules.rules.inc, line 18

which is:
$fields = entity_metadata_get_properties('privatemsg_message');

This causes a PHP WSOD, the dependency should be required to make sure it can't be activated without the module enabled. Either that or a graceful error/notice or something so it doesn't totally crash and require me to use hack the module so drush can work so I can disable the module :)

CommentFileSizeAuthor
#2 remove_entity_metadata_dependency.patch1.01 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I didn't know that entity_metadata is deprecated :)

Looks like that function has been incorporated into entity.module, but I need to figure out which one.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new remove_entity_metadata_dependency.patch1.01 KB

With this patch, entity_metadata shouldn't be required anymore. Please test.

jyee’s picture

jyee commented
Status: Needs review » Reviewed & tested by the community

Patch works perfectly. Thanks for the good work.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reporting and testing, commited!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.