db_rewrite_sql is gone from D7, so the coder review just told me ""SELECT FROM {node}" statements should probably be wrapped in d"

Comments

Jody Lynn’s picture

Jody Lynn
she/her
Primary language English
CreditAttribution: Jody Lynn commented

Likewise, review references to update_sql need to go.

mlncn’s picture

mlncn CreditAttribution: mlncn commented
Issue tags: +dgd7

Ah... yes. That explains this bogus report:

severity: critical Line 425: Potential problem: "SELECT FROM {node}" statements should probably be wrapped in d and with the alias for {node} table defined (e.g. {node} n)

$result = db_query("SELECT type, status, COUNT(nid) as NUM FROM {node} n GROUP BY type, status ORDER BY type ASC, status DESC")->fetchAll(PDO::FETCH_ASSOC);

darksnow’s picture

darksnow CreditAttribution: darksnow commented

I was getting this too. I take it I can safely ignore that "Critical" problem reported by Coder?

Is there an update to Coder that I should be using instead of 7.x-1.0-beta6?

solotandem’s picture

solotandem CreditAttribution: solotandem commented

Run the dev release to get the latest updates.

stella’s picture

stella CreditAttribution: stella commented
Status: Active » Fixed

Yep, this is fixed in the dev version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

salientknight’s picture

salientknight CreditAttribution: salientknight commented

I have the dev version and I am still getting this error...