The activity() function in the pay_transaction class returns all the activities associated with the transaction and loads them into pay_transaction->activity. The problem is that it will go through check_plain() and throw an error, since it should be a string and not an array.

I would suggest to rename the function and use it in plural.

CommentFileSizeAuthor
#1 pay.1019774_01.patch2.43 KBsgabe

Comments

sgabe’s picture

sgabe commented
Status: Active » Needs review
StatusFileSize
new pay.1019774_01.patch2.43 KB

See the attached patch.

allie micka’s picture

allie micka
she/her
commented
Status: Needs review » Postponed (maintainer needs more info)

Hi sgabe,

$activity->activity is inherently confusing and inaccurate. I have renamed this value to $activity->action. Do you think this patch is still valid/necessary?

Thanks a lot!