Comments

marvil07’s picture

Status: Active » Needs review
Issue tags: +git phase 2
sdboyer’s picture

Status: Needs review » Needs work
StatusFileSize
new3.98 KB

Counter-patch which touches up and changes some of these options. Just a note that we really don't want to make the big listing of repositories in the info, as there are potentially thousands of repositories on a site like, say, d.o.

Now this patch just needs support for tokenization of VersioncontrolLabel and VersioncontrolItemRevision and we'll be all set to go.

marvil07’s picture

Marking the older #788134: Re-add rules integration when API is stable as duplicate of this, since this has patches.

sdboyer’s picture

Soooo leftovers.

cvangysel’s picture

Assigned: sirkitree » cvangysel

I wrote some Token support for my GSoC fork which main task is to actually implement all these things (#498156: Integrate with triggers and the activity module).

See http://drupalcode.org/sandbox/stophr/1140414.git/blobdiff/4dd87c602c47f3... for my implementation and please share your thoughts.

Edit: I will add some more tokens the next couple of days and test the ones I've defined for now.

marvil07’s picture

StatusFileSize
new13.18 KB

After analyzing the latest code on gsoc-activity topic branch, related to token integration, I end up thinking that we just want some of those commits(not a merge since for now we only want the token integration). In specific commits:

  • 3e94fc188ce3fc8d3459493b8681f428a62e7205
  • bd73d362ec40e7a06f7821cac996225c4e25c2ec
  • 75d61eecf318c7d21c6387b1a1de2d1ffc0af387
  • 55dbd65ed85e94e649fc9f51500e9b419c269d86

Here I'm attaching an squashed version of them just for convenience, on top of 6.x-2.x
I still need to actually try it and remove extra unneeded spaces.

marvil07’s picture

Assigned: cvangysel » Unassigned
StatusFileSize
new13.02 KB

Another version with less space errors and minor logic changes.
Also add token dependency for the test.
Still pending of real review.

sdboyer’s picture

retagging during triage

marvil07’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs work » Needs review

Moving to D7 and trigger testbot.

marvil07’s picture

D7 version needs new test declared on info file, also fix missing space errors.

Status: Needs review » Needs work

The last submitted patch, 0001-Issue-1020220-by-cvangysel-marvil07-sdboyer-sirkitre.patch, failed testing.

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new15.04 KB

Unfinished port to D7 tokens.

Status: Needs review » Needs work

The last submitted patch, 1020220-versioncontrol-token-12.patch, failed testing.

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new23.82 KB
new15.69 KB
  • Minor fix for dependency: do not use token.
  • Move token integration to new file.
  • Port operation tokens to D7.

Status: Needs review » Needs work

The last submitted patch, 1020220-versioncontrol-token-14.patch, failed testing.

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new14.54 KB
new16.13 KB
  • Branch and tags tokens ported to D7, with tests.
  • Add operation type token.
  • Add chained tokens to current token types.

Status: Needs review » Needs work

The last submitted patch, 1020220-versioncontrol-token-16.patch, failed testing.

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new7.31 KB
new20.72 KB
  • Port one item token, and create a lot more.
  • Other minor fixes.

Status: Needs review » Needs work

The last submitted patch, 1020220-versioncontrol-token-18.patch, failed testing.

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new6.64 KB
new23 KB
  • Event tokens.
  • Other minor fixes.

Status: Needs review » Needs work

The last submitted patch, 1020220-versioncontrol-token-20.patch, failed testing.

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new23.77 KB

Hopefully last fixes.

BTW I love being able to use testbot for the never-ending-time-consuming test runs \o/

marvil07’s picture

Status: Needs review » Needs work

I talked with sdboyer, and he is ok to add this to D7 :-)

After quick chat with davereid, current token maintainer in core, I think I will change the tokens to versioncontrol-something, to follow current implicit convention(not standard, but sounds reasonable), before adding it to upstream.

marvil07’s picture

Status: Needs work » Needs review
StatusFileSize
new21.87 KB
new23.88 KB

Renamed tokens.

I'll add it after passing tests.

marvil07’s picture

Status: Needs review » Fixed

Last patch added to 7.x-1.x.

Since this differs a lot from original code, I think it will not make it for 6.x-2.x, and I guess that's OK.

Status: Fixed » Closed (fixed)
Issue tags: -vc-next

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit fba0f93 on 7.x-1.x, drush-vc-sync-unlock by marvil07:
    Issue #1020220 by marvil07, cvangysel: Reintroduced token integration....

  • Commit fba0f93 on 7.x-1.x by marvil07:
    Issue #1020220 by marvil07, cvangysel: Reintroduced token integration....