Closed (fixed)
Project:
Version Control API
Version:
7.x-1.x-dev
Component:
API module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Jan 2011 at 07:37 UTC
Updated:
15 Apr 2014 at 22:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
marvil07 commentedComment #2
sdboyer commentedCounter-patch which touches up and changes some of these options. Just a note that we really don't want to make the big listing of repositories in the info, as there are potentially thousands of repositories on a site like, say, d.o.
Now this patch just needs support for tokenization of VersioncontrolLabel and VersioncontrolItemRevision and we'll be all set to go.
Comment #3
marvil07 commentedMarking the older #788134: Re-add rules integration when API is stable as duplicate of this, since this has patches.
Comment #4
sdboyer commentedSoooo leftovers.
Comment #5
cvangysel commentedI wrote some Token support for my GSoC fork which main task is to actually implement all these things (#498156: Integrate with triggers and the activity module).
See http://drupalcode.org/sandbox/stophr/1140414.git/blobdiff/4dd87c602c47f3... for my implementation and please share your thoughts.
Edit: I will add some more tokens the next couple of days and test the ones I've defined for now.
Comment #6
marvil07 commentedAfter analyzing the latest code on gsoc-activity topic branch, related to token integration, I end up thinking that we just want some of those commits(not a merge since for now we only want the token integration). In specific commits:
Here I'm attaching an squashed version of them just for convenience, on top of 6.x-2.x
I still need to actually try it and remove extra unneeded spaces.
Comment #7
marvil07 commentedAnother version with less space errors and minor logic changes.
Also add token dependency for the test.
Still pending of real review.
Comment #8
sdboyer commentedretagging during triage
Comment #9
marvil07 commentedMoving to D7 and trigger testbot.
Comment #10
marvil07 commentedD7 version needs new test declared on info file, also fix missing space errors.
Comment #12
marvil07 commentedUnfinished port to D7 tokens.
Comment #14
marvil07 commentedComment #16
marvil07 commentedComment #18
marvil07 commentedComment #20
marvil07 commentedComment #22
marvil07 commentedHopefully last fixes.
BTW I love being able to use testbot for the never-ending-time-consuming test runs \o/
Comment #23
marvil07 commentedI talked with sdboyer, and he is ok to add this to D7 :-)
After quick chat with davereid, current token maintainer in core, I think I will change the tokens to
versioncontrol-something, to follow current implicit convention(not standard, but sounds reasonable), before adding it to upstream.Comment #24
marvil07 commentedRenamed tokens.
I'll add it after passing tests.
Comment #25
marvil07 commentedLast patch added to
7.x-1.x.Since this differs a lot from original code, I think it will not make it for
6.x-2.x, and I guess that's OK.