Undefined $term in function biblio_taxonomy() [#1021006]

Ron,

This evening I came across another small nit with part of the biblio module. The error message this time was:

notice: Undefined variable: term in biblio_taxonomy() (line 2078 of /home/toomreco/drupal-6.20/sites/all/modules/biblio/biblio.module).

I am not sure where in the logic of the code the $term variable is supposed to be coming from. I think that the code that you want there is something like:

  if ($op == 'delete' && isset($type['vid']) &&
    $type['vid'] == variable_get('biblio_keyword_vocabulary', 0)) {

I have changed in my local copy of the code the variable from $term to $type as well as adding a check that $type['vid'] exists. Is this as you intended?

Cheers!!

Comments

Comment #1

rjerome commented 10 January 2011 at 18:32

Yep, that one is just plain wrong!

Should be...

function biblio_taxonomy($op, $type, $array = NULL) {
  if ($op == 'delete' && $type == 'vocabulary' && $array['vid'] == variable_get('biblio_keyword_vocabulary', -1)) {
    variable_del('biblio_keyword_freetagging');
    variable_del('biblio_keyword_vocabulary');
  }
}

http://drupal.org/cvs?commit=478628