Home » Administration » Structure » Menus
Settings
"Undefined index: in menu_configure() (line 682 of /modules/menu/menu.admin.inc)."
$menu_options[$main] isn't defined in the help message for source for the secondary links when
$main was previously set as "No Main Links".
The fix is to change line 682 of /modules/menu/menu.admin.inc
'%main' => $menu_options[$main]
to
'%main' => $main ? $menu_options[$main] : 'none'
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | menu-no-main-links-1021064-14.patch | 1.18 KB | clayball |
| #10 | menu-no-main-links-1021064-9.patch | 1.16 KB | barraponto |
| #9 | menu-no-main-links-1021064-9.patch | 1.24 KB | barraponto |
| #6 | 1021064.patch | 1.15 KB | montesq |
| #4 | 1021064.patch | 1.16 KB | montesq |
Comments
Comment #1
montesq commentedFind as attached the patch according to the mejd's comment
This patch fixes the error in my case...
Comment #3
montesq commented#1: 1021064.patch queued for re-testing.
Comment #4
montesq commentedpatch in #1 contains a part not relative to the current issue...
This new patch is "clean"
Comment #6
montesq commentedgrrr sorry but I'm really silly, find as attached another patch...
Time to sleep for me
Comment #7
Oleksa-1 commentedthx
Comment #8
dawehnerComment #9
barrapontoThis is mostly the same patch, for 7.x.
Comment #10
barrapontolast patch had some weird objects in it....
Comment #11
webchickCommitted to 8.x and 7.x. Thanks!
Comment #12
tr commentedThis patch adds:
array('%main' => $main ? $menu_options[$main] : 'none')The string 'none' needs to be wrapped in t(). Not sure 'none' is the proper word to use here either. Also, should probably use isset($menu_options[$main]) instead of just testing if ($main).
There's another patch RTBC in #1080026: Undefined index: in menu_configure() (line 682 of menu_admin.inc) that addresses this same issue, but uses t() and isset(). I'm marking that one as duplicate of this, but the patch in there should be considered as a better way to fix this problem.
Comment #13
webchickWow, sorry. I'm not sure what I was smoking when I committed that patch; you're absolutely right.
OTOH, I don't think we can use the patch in #1080026: Undefined index: in menu_configure() (line 682 of menu_admin.inc) because it adds a new string. t('none') is also in book.module, so if we were to just wrap t() around 'none' that would resolve this issue without breaking string freeze.
That should be pretty easy for someone to do. :)
Comment #14
clayball commentedadded t() wrapper.
Comment #15
clayball commentedI forgot to set the status on this :)
This patch also applied cleanly to D7.
Comment #16
Zgear commented#14: menu-no-main-links-1021064-14.patch queued for re-testing.
Comment #17
xjmRegarding #15, note that we want to have the needs backport tag even if the backport is exactly the same patch. :)
Retests pass, and this is sort of a no-brainer. RTBC.
Comment #18
catchYeah just to reiterate, if it doesn't say 'needs backport to D7' in the tags, I'm liable to just mark it fixed for 8.x and forget about 7.x since I'm only allowed to commit to 8.x and that tag is the main thing to remind me things need to be moved back afterwards.
Committed/pushed to 8.x, moving to 7.x.
Comment #19
webchickCommitted and pushed to 7.x. Thanks!