I've noticed that uninstalling the module keeps the settings per menu item. I uninstalled to reinstall and the settings for a menu item stay the same. This means that there's stuff left in the database that nobody needs who uninstalled the module. I'm no programmer so I can't help with writing the patch, but thought I'd leave it here as a feature request :)

Comments

aschiwi’s picture

Update: settings are saved in menu_links table (options column). I guess it would be better to introduce a new table instead of using menu_links' options column, because that one will be hard to remove upon uninstall.

damienmckenna’s picture

Version: 6.x-1.2 » 7.x-1.x-dev
Issue tags: +D7 stable release blocker, +D6 stable release blocker

Tag.

damienmckenna’s picture

Tag.

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new1.18 KB

This appears to work.

damienmckenna’s picture

StatusFileSize
new1.17 KB

A slight change to the uninstall script that uses the mlid rather than the router_path.

damienmckenna’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
StatusFileSize
new1.11 KB

D6 version of #5.

damienmckenna’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new1.17 KB

Trying the D7 version again.

damienmckenna’s picture

Committed.

damienmckenna’s picture

Status: Needs review » Fixed
damienmckenna’s picture

Status: Fixed » Closed (fixed)

Closing this in the interest of tidying up the issue queue after the release of 7.x-1.0 / 6.x-1.3.