Per post title, would love to see this updated to 5.x.

CommentFileSizeAuthor
#1 patch_89.txt5.81 KBspecialtouch

Comments

specialtouch’s picture

StatusFileSize
new5.81 KB

This patch does the trick.

specialtouch’s picture

Status: Active » Needs review
tknospdr’s picture

Would like to see this as well.

Thanks,
David

tknospdr’s picture

Patching didn't work for me, I got this output:

Last login: Sat Jan 20 11:18:59 on ttyp1
Welcome to Darwin!
ncc1701e:~ david$ cd Desktop/phone
ncc1701e:~/Desktop/phone david$ patch < ~/Desktop/patch_89.txt 
(Stripping trailing CRs from patch.)
patching file phone.module
Hunk #1 FAILED at 1.
Hunk #3 FAILED at 28.
Hunk #4 succeeded at 170 (offset 25 lines).
Hunk #5 succeeded at 217 (offset 25 lines).
Hunk #6 succeeded at 232 (offset 25 lines).
Hunk #7 succeeded at 243 (offset 25 lines).
Hunk #8 succeeded at 262 (offset 25 lines).
Hunk #9 succeeded at 281 (offset 25 lines).
2 out of 9 hunks FAILED -- saving rejects to file phone.module.rej
The next patch would create the file phone.info,
which already exists!  Assume -R? [n] 
Apply anyway? [n] y
(Stripping trailing CRs from patch.)
patching file phone.info
Patch attempted to create file phone.info, which already exists.
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file phone.info.rej
ncc1701e:~/Desktop/phone david$
moshe weitzman’s picture

lets get this in before the field module API changes too much :)

appel’s picture

The patch seems to work for me.

add1sun’s picture

Status: Needs review » Reviewed & tested by the community

Patch works for me too. tknospdr are you patching against HEAD or the 4.7 dev? This goes against HEAD cleanly for me. As far as I can see this is a REALLY simple patch and is RTBC. Only thing is all the minor formatting changes that make the patch messy.

srcerer’s picture

Any idea when and if this will be committed?

zach harkey’s picture

+1

Seriously, seems pretty straightforward, any reason why it's languishing?

thomaslaw’s picture

+1

Need this as well.

srcerer’s picture

Anyone know what is going on? Patch worked for me but I realized tonight that the phone number isn't displaying at all. I put in a fix locally for the callback. Not sure if this module is still active. Seems really useful...

WebWeasel’s picture

This would be very useful. Subscribing.

colinjallen’s picture

I found this patch to work on HEAD, but not 4.7.x-1.x-dev.

As that is the case, is it possible to put the HEAD under "Releases," untill a 5.x module is completed?

thierry_gd’s picture

Version: master » 5.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Just updated the module to drupal 5

Anonymous’s picture

Status: Fixed » Closed (fixed)