Providing views integration with flag_notes fields will provide ability for users to create like a My Bookmarks space that provides URL, page title, and notes that user stores against the flag

Comments

Ravi.J’s picture

StatusFileSize
new1.1 KB

Patch attached

Ravi.J’s picture

Status: Active » Needs review
alexpott’s picture

I think this needs to be wrapped with

  if (module_exists('flag_note')) {
    //Views relationship
  }

Other than that this makes perfect sense.

Ravi.J’s picture

StatusFileSize
new1.23 KB

Revised patch

alexpott’s picture

StatusFileSize
new54.72 KB

I'm not sure that the relationship options make sense. See image attached.

Especially the line "Include only flagged content" as means is "Include only pages with flag notes". To limit the flag_page views to only flagged content you need to include a different relationship.

Need to write a relationship handler or override the flag_handler_relationship_content for this purpose.

alexpott’s picture

The patch attached provides a new relationship handler which has improved configuration options and messages (see attached image)

rickvug’s picture

The patch in #6 is working well for me. I'm now able to build a "my bookmarks" block that use's a user's individual bookmark titles provided by flag note. No problems encountered.

rickvug’s picture

Status: Needs review » Reviewed & tested by the community

Code looks clean and follows all standards from what I can see. Seeing as how two developers have touched this patch and it is working for multiple users I'm marking RTBC.

alexpott’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Feature included 6.x-2.1 release.