Undefined index: show_books in linkit_node_linkit_load_plugins()

Thanks for the report, I will take a look at this asap

Need some more info.

Regarding "Notice: Undefined index:"
Have you updated to Linkit 7.x from Linkit 6.x?

About the "http://www", I dont see what this is happeing, this works grate in D6 but it feels like they have shanged something with the menu URI stuff in D7. (And this should be an other issue I think)

Would be awesome with some help with that thanks.

Thanks for the feedback.

Do you have any dev site? It would be grate if you could test the "Notice: Undefined index:" with the latest Linkit dev version on that because Linkit 7.x-1.0 release is very odd. Many fixes isnt included in that, I cant see why but unfortunately thats the case.

fresh drupal 7 installation with Linkit 7.x-1.0, error after typing "/", need to shield slash

An AJAX HTTP error occurred.
HTTP Result Code: 404
Debugging information follows.
Path: http://blog/admin/linkit/autocomplete
StatusText: Not Found
ResponseText: 
Object not found!
*/-->
Object not found!
The requested URL was not found on this server.
The link on the
referring
page seems to be wrong or outdated. Please inform the author of
that page
about the error.
If you think this is a server error, please contact
the webmaster.
Error 404
blog
Wed Jan 12 11:57:56 2011
Apache/2.2.17 (Unix) mod_ssl/2.2.17 OpenSSL/1.0.0c DAV/2 PHP/5.2.17 with Suhosin-Patch

anon:"It would be grate if you could test the "Notice: Undefined index:" with the latest Linkit dev version"

same...

@caschbre: Its ok to change version.

This issue has two issues.

• Slashes doesnt work with autocomplete
• Notice: Undefined index: show_books

I submitted a new issue for #1024460: Slashes doesnt work with autocomplete (waiting for D7 update to fix this) so we can keep this this apart.

As already noted in #3, the fact whether the book module is enabled/disabled triggers these notices as this fact shows/hides the option on the settings form and thus saves/deletes this setting in the settings. So just changing that line of code from:

    // Add Title of the book a node belong to
    if ($settings['display_settings']['show_books'] && $node->bid) {

to:

    // Add Title of the book a node belong to
    if (!empty($settings['display_settings']['show_books']) && $node->bid) {

prevents the notices from appearing.

No, you are checking a setting from the "administer linkit settings" form. If you enable the book module but do not visit the "administer linkit settings" form again it won't still be available. So just checking if it exists and has a non-empty value (exactly what empty() does) is enough.

Thanks for the suggerstion fietserwin but this patch has a diffrent solution.

I have this function called _linkit_node_get_default_settings that will set all necessary variables into the settings array just to get rid of all this Undefined notices.

Please test this, and tell me what you think. Thanks.

$settings['display_settings']['show_books'] is used in two line of code.
43 and 94 (latest dev)

Its used once for each result you get from the node plugin.

Let say you give an "D" and get 8 results, this error should be report 9 errors.
1 for the settings where we build the SQL query, and 8 times for results (1 for each result row)

But I will look at this, to make sure its not cycling through too many times.

Regarding my patch, that should work, cant see why it woulnd. Its append all "missing" variables to $settings['display_settings']
Any idéas why this not work?

Patch works for me and looking at the code it indeed should work. Stepping through with a debugger I can now see the 'show_books' element being added to the settings. And this solution looks more fool proof to me than my quick patch.

@cashbre: your remark about taxonomy module is right: same type of patch should be applied to function _linkit_taxonomy_get_default_settings(&$settings)

@fietserwin: Thanks for testing.
Do we need to change _linkit_taxonomy_get_default_settings(&$settings)?

If no settings exists in the variable DB table (variable name = linkit_term), that function should applie the missing values in the settings array. Does that fail right now?

Grate, Thanks all for testing.
I will commit this when I get home today.

Thanks for reporting, reviewing, and testing!
Committed to DRUPAL-7--1 branch.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

#20: I'm not sure as it is indeed only 1 setting. I did no test taxonomy, I just saw the same pattern applied there. The pattern being: trying to merge an array recursively (while neither += nor array_merge are recursive). So perhaps better to use the same working pattern at all places, as the moment you add a 2nd setting, this error might be reintroduced on that spot.

ah I see, Ok I will do that.